Reason for revert: Necessary calls were "protected" by RTC_DCHECKs, that were optimized away in some release builds. Replacing the RTC_DCHECKs with EXPECTs. Original issue's description: > Revert of Add optional visualization file writers to VideoProcessor tests. (patchset #4 id:220001 of https://codereview.webrtc.org/2700493006/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Add optional visualization file writers to VideoProcessor tests. > > > > The purpose of this visualization CL is to add the ability to record > > video at the source, after encode, and after decode, in the VideoProcessor > > tests. These output files can then be replayed and used as a subjective > > complement to the objective metric plots given by the existing Python > > plotting script. > > > > BUG=webrtc:6634 > > > > Review-Url: https://codereview.webrtc.org/2700493006 > > Cr-Commit-Position: refs/heads/master@{#16738} > > Committed:872104ac41> > TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6634 > > Review-Url: https://codereview.webrtc.org/2708103002 > Cr-Commit-Position: refs/heads/master@{#16745} > Committed:2a8135a174TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2706123003 Cr-Commit-Position: refs/heads/master@{#16769}
89 lines
2.8 KiB
C++
89 lines
2.8 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_TEST_TESTSUPPORT_FRAME_WRITER_H_
|
|
#define WEBRTC_TEST_TESTSUPPORT_FRAME_WRITER_H_
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <string>
|
|
|
|
#include "webrtc/typedefs.h"
|
|
|
|
namespace webrtc {
|
|
namespace test {
|
|
|
|
// Handles writing of video files.
|
|
class FrameWriter {
|
|
public:
|
|
virtual ~FrameWriter() {}
|
|
|
|
// Initializes the file handler, i.e. opens the input and output files etc.
|
|
// This must be called before reading or writing frames has started.
|
|
// Returns false if an error has occurred, in addition to printing to stderr.
|
|
virtual bool Init() = 0;
|
|
|
|
// Writes a frame of the configured frame length to the output file.
|
|
// Returns true if the write was successful, false otherwise.
|
|
virtual bool WriteFrame(uint8_t* frame_buffer) = 0;
|
|
|
|
// Closes the output file if open. Essentially makes this class impossible
|
|
// to use anymore. Will also be invoked by the destructor.
|
|
virtual void Close() = 0;
|
|
|
|
// Frame length in bytes of a single frame image.
|
|
virtual size_t FrameLength() = 0;
|
|
};
|
|
|
|
// Writes raw I420 frames in sequence.
|
|
class YuvFrameWriterImpl : public FrameWriter {
|
|
public:
|
|
// Creates a file handler. The input file is assumed to exist and be readable
|
|
// and the output file must be writable.
|
|
// Parameters:
|
|
// output_filename The file to write. Will be overwritten if already
|
|
// existing.
|
|
// width, height Size of each frame to read.
|
|
YuvFrameWriterImpl(std::string output_filename, int width, int height);
|
|
~YuvFrameWriterImpl() override;
|
|
bool Init() override;
|
|
bool WriteFrame(uint8_t* frame_buffer) override;
|
|
void Close() override;
|
|
size_t FrameLength() override;
|
|
|
|
protected:
|
|
const std::string output_filename_;
|
|
size_t frame_length_in_bytes_;
|
|
const int width_;
|
|
const int height_;
|
|
FILE* output_file_;
|
|
};
|
|
|
|
// Writes raw I420 frames in sequence, but with Y4M file and frame headers for
|
|
// more convenient playback in external media players.
|
|
class Y4mFrameWriterImpl : public YuvFrameWriterImpl {
|
|
public:
|
|
Y4mFrameWriterImpl(std::string output_filename,
|
|
int width,
|
|
int height,
|
|
int frame_rate);
|
|
~Y4mFrameWriterImpl() override;
|
|
bool Init() override;
|
|
bool WriteFrame(uint8_t* frame_buffer) override;
|
|
|
|
private:
|
|
const int frame_rate_;
|
|
};
|
|
|
|
} // namespace test
|
|
} // namespace webrtc
|
|
|
|
#endif // WEBRTC_TEST_TESTSUPPORT_FRAME_WRITER_H_
|