This reverts commit 97d5e5b32c77bf550f1d788454f2db10ac9fbb1c. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Replace BundleFilter with RtpDemuxer in RtpTransport." > > This reverts commit ea8b62a3e74fe91cd6bf66304839cd5677880a4e. > > Reason for revert: Broke chromium tests. > Original change's description: > > Replace BundleFilter with RtpDemuxer in RtpTransport. > > > > BundleFilter is replaced by RtpDemuxer in RtpTransport for payload > > type-based demuxing. RtpTransport will support MID-based demuxing later. > > > > Each BaseChannel has its own RTP demuxing criteria and when connecting > > to the RtpTransport, BaseChannel will register itself as a demuxer sink. > > > > The inheritance model is changed. New inheritance chain: > > DtlsSrtpTransport->SrtpTransport->RtpTranpsort > > > > NOTE: > > When RTCP packets are received, Call::DeliverRtcp will be called for > > multiple times (webrtc:9035) which is an existing issue. With this CL, > > it will become more of a problem and should be fixed. > > > > Bug: webrtc:8587 > > Change-Id: I1d8a00443bd4bcbacc56e5e19b7294205cdc38f0 > > Reviewed-on: https://webrtc-review.googlesource.com/61360 > > Commit-Queue: Zhi Huang <zhihuang@webrtc.org> > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#22613} > > TBR=steveanton@webrtc.org,deadbeef@webrtc.org,zhihuang@webrtc.org > > Change-Id: If245da9d1ce970ac8dab7f45015e9b268a5dbcbd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8587 > Reviewed-on: https://webrtc-review.googlesource.com/64860 > Reviewed-by: Zhi Huang <zhihuang@webrtc.org> > Commit-Queue: Zhi Huang <zhihuang@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22614} TBR=steveanton@webrtc.org,deadbeef@webrtc.org,zhihuang@webrtc.org Change-Id: I3c272588ab4388ecadc4edc6786d5195c701855f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8587 Reviewed-on: https://webrtc-review.googlesource.com/64862 Commit-Queue: Zhi Huang <zhihuang@webrtc.org> Reviewed-by: Zhi Huang <zhihuang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22615}
80 lines
2.4 KiB
C++
80 lines
2.4 KiB
C++
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef PC_RTPTRANSPORTTESTUTIL_H_
|
|
#define PC_RTPTRANSPORTTESTUTIL_H_
|
|
|
|
#include "call/rtp_packet_sink_interface.h"
|
|
#include "modules/rtp_rtcp/source/rtp_packet_received.h"
|
|
#include "pc/rtptransportinternal.h"
|
|
#include "rtc_base/sigslot.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Used to handle the signals when the RtpTransport receives an RTP/RTCP packet.
|
|
// Used in Rtp/Srtp/DtlsTransport unit tests.
|
|
class TransportObserver : public RtpPacketSinkInterface,
|
|
public sigslot::has_slots<> {
|
|
public:
|
|
TransportObserver() {}
|
|
|
|
explicit TransportObserver(RtpTransportInternal* rtp_transport) {
|
|
rtp_transport->SignalRtcpPacketReceived.connect(
|
|
this, &TransportObserver::OnRtcpPacketReceived);
|
|
rtp_transport->SignalReadyToSend.connect(this,
|
|
&TransportObserver::OnReadyToSend);
|
|
}
|
|
|
|
// RtpPacketInterface override.
|
|
void OnRtpPacket(const RtpPacketReceived& packet) override {
|
|
rtp_count_++;
|
|
last_recv_rtp_packet_ = packet.Buffer();
|
|
}
|
|
|
|
void OnRtcpPacketReceived(rtc::CopyOnWriteBuffer* packet,
|
|
const rtc::PacketTime& packet_time) {
|
|
RTC_LOG(LS_INFO) << "Received an RTCP packet.";
|
|
rtcp_count_++;
|
|
last_recv_rtcp_packet_ = *packet;
|
|
}
|
|
|
|
int rtp_count() const { return rtp_count_; }
|
|
int rtcp_count() const { return rtcp_count_; }
|
|
|
|
rtc::CopyOnWriteBuffer last_recv_rtp_packet() {
|
|
return last_recv_rtp_packet_;
|
|
}
|
|
|
|
rtc::CopyOnWriteBuffer last_recv_rtcp_packet() {
|
|
return last_recv_rtcp_packet_;
|
|
}
|
|
|
|
void OnReadyToSend(bool ready) {
|
|
ready_to_send_signal_count_++;
|
|
ready_to_send_ = ready;
|
|
}
|
|
|
|
bool ready_to_send() { return ready_to_send_; }
|
|
|
|
int ready_to_send_signal_count() { return ready_to_send_signal_count_; }
|
|
|
|
private:
|
|
bool ready_to_send_ = false;
|
|
int rtp_count_ = 0;
|
|
int rtcp_count_ = 0;
|
|
int ready_to_send_signal_count_ = 0;
|
|
rtc::CopyOnWriteBuffer last_recv_rtp_packet_;
|
|
rtc::CopyOnWriteBuffer last_recv_rtcp_packet_;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // PC_RTPTRANSPORTTESTUTIL_H_
|