239ac8a4e2
This is a reland of 003c9be817817ed0e3aef3f50c78ae5cb31bc0ff Found some downstream code that relies on NetworkMonitorFactory::SetFactory, so I'm adding those methods back temporarily. BasicNetworkManager will fall back to the static factory if the one passed into PeerConnectionFactory is null. Original change's description: > Pass NetworkMonitorFactory through PeerConnectionFactory. > > Previously the instance was set through a static method, which was > really only done because it was difficult to add new > PeerConnectionFactory construction arguments at the time. > > Now that we have PeerConnectionFactoryDependencies it's easy to clean > this up. > > I'm doing this because I plan to add a NetworkMonitor implementation > for iOS, and don't want to inherit this ugliness. > > Bug: webrtc:9883 > Change-Id: Id94dc061ab1c7186b81af8547393a6e336ff04c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180241 > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> > Commit-Queue: Taylor <deadbeef@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31815} TBR=hta@webrtc.org, sakal@webrtc.org Bug: webrtc:9883 Change-Id: I2e817c423f21936f87532a9694eb9a0a1b70c212 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180722 Reviewed-by: Taylor <deadbeef@webrtc.org> Commit-Queue: Taylor <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31824}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.