This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16.
Reason for revert:
Breaks Chrome FYI:
/b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
-> returned 1
ERROR at //build/split_static_library.gni:12:5: Dependency not allowed.
static_library(target_name) {
^----------------------------
The item //content/renderer:renderer
can not depend on //third_party/webrtc/media:rtc_internal_video_codecs
because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [
//third_party/webrtc/*
//third_party/webrtc_overrides/*
]
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout
Original change's description:
> GN rtc_* templates: Set default visibility to webrtc_root + "/*"
>
> This means that by default, targets are visible to everything under
> the WebRTC root, but not visible to anything else.
>
> API targets are manually tagged with visibility "*", so that targets
> outside the WebRTC tree can see them.
>
> BUG=webrtc:8254
>
> Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509
> Reviewed-on: https://webrtc-review.googlesource.com/24140
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21548}
TBR=mbonadei@webrtc.org,kwiberg@webrtc.org
Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8254
Reviewed-on: https://webrtc-review.googlesource.com/38760
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21555}
161 lines
4.2 KiB
Plaintext
161 lines
4.2 KiB
Plaintext
# Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
import("../webrtc.gni")
|
|
|
|
visibility = [ ":*" ]
|
|
|
|
rtc_static_library("voice_engine") {
|
|
visibility += [ "*" ]
|
|
sources = [
|
|
"channel.cc",
|
|
"channel.h",
|
|
"channel_manager.cc",
|
|
"channel_manager.h",
|
|
"channel_proxy.cc",
|
|
"channel_proxy.h",
|
|
"include/voe_base.h",
|
|
"include/voe_errors.h",
|
|
"shared_data.cc",
|
|
"shared_data.h",
|
|
"transport_feedback_packet_loss_tracker.cc",
|
|
"transport_feedback_packet_loss_tracker.h",
|
|
"utility.cc",
|
|
"utility.h",
|
|
"voe_base_impl.cc",
|
|
"voe_base_impl.h",
|
|
"voice_engine_impl.cc",
|
|
"voice_engine_impl.h",
|
|
]
|
|
|
|
if (is_win) {
|
|
cflags = [
|
|
# TODO(kjellander): Bug 261: fix this warning.
|
|
"/wd4373", # Virtual function override.
|
|
]
|
|
}
|
|
|
|
if (!build_with_chromium && is_clang) {
|
|
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
|
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
|
}
|
|
|
|
deps = [
|
|
":audio_level",
|
|
"..:webrtc_common",
|
|
"../:typedefs",
|
|
"../api:array_view",
|
|
"../api:audio_mixer_api",
|
|
"../api:call_api",
|
|
"../api:libjingle_peerconnection_api",
|
|
"../api:optional",
|
|
"../api:refcountedbase",
|
|
"../api:transport_api",
|
|
"../api/audio_codecs:audio_codecs_api",
|
|
"../audio/utility:audio_frame_operations",
|
|
"../call:rtp_interfaces",
|
|
"../common_audio",
|
|
"../logging:rtc_event_log_api",
|
|
"../modules:module_api",
|
|
"../modules/audio_coding",
|
|
"../modules/audio_coding:audio_format_conversion",
|
|
"../modules/audio_coding:audio_network_adaptor_config",
|
|
"../modules/audio_device",
|
|
"../modules/audio_processing",
|
|
"../modules/bitrate_controller",
|
|
"../modules/media_file",
|
|
"../modules/pacing",
|
|
"../modules/rtp_rtcp",
|
|
"../modules/rtp_rtcp:rtp_rtcp_format",
|
|
"../modules/utility",
|
|
"../rtc_base:checks",
|
|
"../rtc_base:rate_limiter",
|
|
"../rtc_base:rtc_base_approved",
|
|
"../rtc_base:rtc_task_queue",
|
|
"../system_wrappers",
|
|
"../system_wrappers:field_trial_api",
|
|
"../system_wrappers:metrics_api",
|
|
]
|
|
}
|
|
|
|
rtc_static_library("audio_level") {
|
|
visibility += [
|
|
":voice_engine",
|
|
"../audio:audio",
|
|
]
|
|
sources = [
|
|
"audio_level.cc",
|
|
"audio_level.h",
|
|
]
|
|
|
|
deps = [
|
|
"..:webrtc_common",
|
|
"../:typedefs",
|
|
"../common_audio",
|
|
"../modules:module_api",
|
|
"../rtc_base:rtc_base_approved",
|
|
]
|
|
}
|
|
|
|
if (rtc_include_tests) {
|
|
rtc_test("voice_engine_unittests") {
|
|
visibility += [ "*" ]
|
|
deps = [
|
|
":voice_engine",
|
|
"../api/audio_codecs:builtin_audio_decoder_factory",
|
|
"../common_audio",
|
|
"../modules:module_api",
|
|
"../modules/audio_coding",
|
|
"../modules/audio_device",
|
|
"../modules/audio_processing",
|
|
"../modules/media_file",
|
|
"../modules/rtp_rtcp:rtp_rtcp_format",
|
|
"../modules/utility",
|
|
"../modules/video_capture:video_capture",
|
|
"../rtc_base:checks",
|
|
"../rtc_base:rtc_base_approved",
|
|
"../rtc_base:rtc_base_tests_utils",
|
|
"../system_wrappers",
|
|
"../test:test_common",
|
|
"../test:test_main",
|
|
"../test:video_test_common",
|
|
"//testing/gmock",
|
|
"//testing/gtest",
|
|
]
|
|
|
|
if (is_android) {
|
|
deps += [ "//testing/android/native_test:native_test_native_code" ]
|
|
shard_timeout = 900
|
|
}
|
|
|
|
sources = [
|
|
"channel_unittest.cc",
|
|
"transport_feedback_packet_loss_tracker_unittest.cc",
|
|
"utility_unittest.cc",
|
|
"voe_base_unittest.cc",
|
|
]
|
|
|
|
data = [
|
|
"../resources/utility/encapsulated_pcm16b_8khz.wav",
|
|
"../resources/utility/encapsulated_pcmu_8khz.wav",
|
|
]
|
|
|
|
if (is_win) {
|
|
cflags = [
|
|
# TODO(kjellander): Bug 261: fix this warning.
|
|
"/wd4373", # Virtual function override.
|
|
]
|
|
}
|
|
|
|
if (!build_with_chromium && is_clang) {
|
|
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
|
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
|
}
|
|
}
|
|
}
|