219d8ce889
This patch improves handshake wrt GOOG_PING support so that - if goog_ping_enable: sender send it's goog-ping version until it gets STUN_BINDING_RESPONSE - receiver only sends it's goog-ping-version if getting a goog-ping-version in the request This means that the overhead of STUN_ATTR_GOOG_MISC_INFO is only - added on STUN_BINDING_REQUEST until a response is received. - added on STUN_BINDING_RESPONSE if remote peer request it. This is wire compatible with older versions so that - new sender will enable GOOG_PING with new/old receiver. - old sender will enable GOOG_PING with old receiver. - old version will not enable GOOG_PING with new receiver (receiver expecting sender to announce first). BUG: webrtc:11100 Change-Id: Ib3434c593988188150f4c7506918139aaf138d0c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165787 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30269}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.