441dbf9a56
This reverts commit c79f1d8cfb48c348692320b05fa31598ed7067ca. Reason for revert: Breaks downstream project. Original change's description: > Add scaling interface to VideoFrameBuffer > > This can be overriden for kNative frame types to perform scaling efficiently. > > Default implementations for existing buffer types require actual > buffer implementation, thus this CL also merges "video_frame" > with "video_frame_I420" build targets. > > Bug: webrtc:11976, chromium:1132299 > Change-Id: I3bf5f6bf179db5e7ab165b1c2301980043a08765 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186303 > Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> > Reviewed-by: Niels Moller <nisse@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/master@{#32352} TBR=mbonadei@webrtc.org,sakal@webrtc.org,ilnik@webrtc.org,nisse@webrtc.org,stefan@webrtc.org,eshr@google.com Change-Id: I86ac697bf963ef7e2c4f2ed34c3a7bf04f4f1ce1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:11976 Bug: chromium:1132299 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187344 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32354}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.