Reason for revert:
Revert breaks other uses, a fix will be rolled into Chromium instead.
Original issue's description:
> Revert of Remove ignored return code from modules. (patchset #3 id:40001 of https://codereview.webrtc.org/1703833002/ )
>
> Reason for revert:
> Breaks Chromium.
>
> Original issue's description:
> > Remove ignored return code from modules.
> >
> > ModuleProcessImpl doesn't act on return codes and having them around is
> > confusing (it's unclear what an error return code here would do even).
> >
> > BUG=
> > R=tommi@webrtc.org
> >
> > Committed: f14c47a58c
>
> TBR=tommi@webrtc.org,pbos@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/da33a8a2a22f6d19ba2a8cce963beafbdbaa8fd8
> Cr-Commit-Position: refs/heads/master@{#11761}
TBR=tommi@webrtc.org,torbjorng@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1737013002
Cr-Commit-Position: refs/heads/master@{#11762}
58 lines
1.4 KiB
C++
58 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_VOICE_ENGINE_MONITOR_MODULE_H
|
|
#define WEBRTC_VOICE_ENGINE_MONITOR_MODULE_H
|
|
|
|
#include "webrtc/base/criticalsection.h"
|
|
#include "webrtc/base/thread_annotations.h"
|
|
#include "webrtc/modules/include/module.h"
|
|
#include "webrtc/typedefs.h"
|
|
#include "webrtc/voice_engine/voice_engine_defines.h"
|
|
|
|
class MonitorObserver
|
|
{
|
|
public:
|
|
virtual void OnPeriodicProcess() = 0;
|
|
protected:
|
|
virtual ~MonitorObserver() {}
|
|
};
|
|
|
|
|
|
namespace webrtc {
|
|
namespace voe {
|
|
|
|
class MonitorModule : public Module
|
|
{
|
|
public:
|
|
int32_t RegisterObserver(MonitorObserver& observer);
|
|
|
|
int32_t DeRegisterObserver();
|
|
|
|
MonitorModule();
|
|
|
|
virtual ~MonitorModule();
|
|
public: // module
|
|
int64_t TimeUntilNextProcess() override;
|
|
|
|
void Process() override;
|
|
|
|
private:
|
|
rtc::CriticalSection _callbackCritSect;
|
|
MonitorObserver* _observerPtr GUARDED_BY(_callbackCritSect);
|
|
int64_t _lastProcessTime;
|
|
};
|
|
|
|
} // namespace voe
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // VOICE_ENGINE_MONITOR_MODULE
|