admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/webrtc/modules/audio_coding/codecs/isac/fix/source
History
kwiberg 64208e5523 Fix UBSan errors (left shift of negative value) 
I've settled on replacing x << n with x * (1 << n); this gets rid of
the "left shift of negative value" warning, but will still trigger
undefined behavior if the multiplication overflows. It also still
looks like a left shift, which is good for the readability of the
fixed-point code.

(The compiler is smart enough to recognize that the
multiplication+shift is just a shift, for both variable and constant
shift amounts, so the generated code should not change.)

BUG=chromium:603491

Review-Url: https://codereview.webrtc.org/1989803002
Cr-Commit-Position: refs/heads/master@{#12845}
2016-05-23 10:28:35 +00:00
..
arith_routines_hist.c
Refactor audio_coding/codecs/isac/fix: Removed usage of trivial macro WEBRTC_SPL_LSHIFT_W32()
2015-04-02 04:59:44 +00:00
arith_routines_logist.c
Reland "Upconvert various types to int.", isac portion.
2015-06-12 01:19:37 +00:00
arith_routines.c
audio_coding/codecs/isac/fix: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>"
2014-10-28 13:05:43 +00:00
arith_routins.h
Reland "Upconvert various types to int.", isac portion.
2015-06-12 01:19:37 +00:00
audio_decoder_isacfix.cc
audio_coding: rename interface -> include
2015-10-29 10:31:11 +00:00
audio_encoder_isacfix.cc
audio_coding: rename interface -> include
2015-10-29 10:31:11 +00:00
bandwidth_estimator.c
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
bandwidth_estimator.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
codec.h
Remove runtime NEON detection
2016-05-17 17:56:48 +00:00
decode_bwe.c
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
decode_plc.c
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
decode.c
Fix UBSan errors (left shift of negative value)
2016-05-23 10:28:35 +00:00
encode.c
Match existing type usage better.
2015-06-11 19:56:03 +00:00
entropy_coding_mips.c
Reland rev 7041 with BUILD.gn files.
2014-09-04 13:28:48 +00:00
entropy_coding_neon.c
Change intrinsic code in isac fix to let it pass chrome clang compiler.
2013-03-12 17:45:41 +00:00
entropy_coding.c
Fix UBSan errors (left shift of negative value)
2016-05-23 10:28:35 +00:00
entropy_coding.h
Remove runtime NEON detection
2016-05-17 17:56:48 +00:00
fft.c
Refactor audio_coding/codecs/isac: Removed usage of macro WEBRTC_SPL_MUL_16_16
2015-03-13 12:59:36 +00:00
fft.h
WebRtc_Word32 => int32_t etc. in audio_coding/
2013-04-09 00:28:06 +00:00
filterbank_internal.h
Remove runtime NEON detection
2016-05-17 17:56:48 +00:00
filterbank_tables.c
…
filterbank_tables.h
Reland rev 7041 with BUILD.gn files.
2014-09-04 13:28:48 +00:00
filterbanks_mips.c
MIPS optimizations for ISAC (patch #2)
2014-07-21 16:43:13 +00:00
filterbanks_neon.c
Fix AppRTCDemo crash under iOS armv7 devices
2015-06-15 06:57:00 +00:00
filterbanks_unittest.cc
Remove runtime NEON detection
2016-05-17 17:56:48 +00:00
filterbanks.c
Fix UBSan errors (left shift of negative value)
2016-05-23 10:28:35 +00:00
filters_mips.c
MIPS optimizations for ISAC (patch #1)
2014-06-10 18:13:15 +00:00
filters_neon.c
Refactor audio_coding/codecs/isac: Removed usage of macro WEBRTC_SPL_MUL_16_16
2015-03-13 12:59:36 +00:00
filters_unittest.cc
Remove runtime NEON detection
2016-05-17 17:56:48 +00:00
filters.c
Refactor audio_coding/codecs/isac/fix: Removed usage of trivial macro WEBRTC_SPL_LSHIFT_W32()
2015-04-02 04:59:44 +00:00
initialize.c
Refactor audio_coding/codecs/isac: Removed usage of macro WEBRTC_SPL_MUL_16_16
2015-03-13 12:59:36 +00:00
isac_fix_type.h
audio_coding: rename interface -> include
2015-10-29 10:31:11 +00:00
isacfix.c
Remove runtime NEON detection
2016-05-17 17:56:48 +00:00
lattice_armv7.S
system_wrappers: rename interface -> include
2015-10-28 17:17:50 +00:00
lattice_c.c
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
lattice_mips.c
Revert "Avoiding size_t in MIPS."
2015-08-31 18:44:05 +00:00
lattice_neon.c
Fix bug in WebRtcIsacfix_FilterMaLoopNeon.
2015-04-01 09:43:22 +00:00
lattice.c
Fix UBSan errors (left shift of negative value)
2016-05-23 10:28:35 +00:00
lpc_masking_model_mips.c
MIPS optimizations for ISAC (patch #2)
2014-07-21 16:43:13 +00:00
lpc_masking_model_unittest.cc
system_wrappers: rename interface -> include
2015-10-28 17:17:50 +00:00
lpc_masking_model.c
Refactor audio_coding/codecs/isac/fix: Removed usage of macro WEBRTC_SPL_MUL_16_16_RSFT
2015-04-10 06:06:46 +00:00
lpc_masking_model.h
Replace asm NEON function by intrinsics implementation on ARMv7
2015-05-06 08:39:37 +00:00
lpc_tables.c
WebRtc_Word32 => int32_t etc. in audio_coding/
2013-04-09 00:28:06 +00:00
lpc_tables.h
Reland rev 7041 with BUILD.gn files.
2014-09-04 13:28:48 +00:00
OWNERS
Make everyone an OWNER for .gyp/.gypi add/delete purposes, non-talk/ edition.
2014-04-14 20:08:03 +00:00
pitch_estimator_c.c
Remove runtime NEON detection
2016-05-17 17:56:48 +00:00
pitch_estimator_mips.c
system_wrappers: rename interface -> include
2015-10-28 17:17:50 +00:00
pitch_estimator.c
system_wrappers: rename interface -> include
2015-10-28 17:17:50 +00:00
pitch_estimator.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
pitch_filter_armv6.S
system_wrappers: rename interface -> include
2015-10-28 17:17:50 +00:00
pitch_filter_c.c
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
pitch_filter_mips.c
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
pitch_filter.c
WebRtcIsacfix_PitchFilter: Don't read uninitialized array entries
2016-03-18 05:17:21 +00:00
pitch_gain_tables.c
WebRtc_Word32 => int32_t etc. in audio_coding/
2013-04-09 00:28:06 +00:00
pitch_gain_tables.h
Reland rev 7041 with BUILD.gn files.
2014-09-04 13:28:48 +00:00
pitch_lag_tables.c
WebRtc_Word32 => int32_t etc. in audio_coding/
2013-04-09 00:28:06 +00:00
pitch_lag_tables.h
Reland rev 7041 with BUILD.gn files.
2014-09-04 13:28:48 +00:00
settings.h
Prevent reading outside iSAC bitstream, if the stream is corrupted.
2014-10-07 00:21:02 +00:00
spectrum_ar_model_tables.c
WebRtc_Word32 => int32_t etc. in audio_coding/
2013-04-09 00:28:06 +00:00
spectrum_ar_model_tables.h
Reland rev 7041 with BUILD.gn files.
2014-09-04 13:28:48 +00:00
structs.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
transform_mips.c
Reduce the number of registers used in MIPS optimizations.
2015-04-21 23:52:26 +00:00
transform_neon.c
Fix bug in transform_neon.c in iSAC codec.
2015-05-06 02:25:20 +00:00
transform_tables.c
Replace asm NEON function by intrinsics implementation on ARMv7
2015-05-06 08:39:37 +00:00
transform_unittest.cc
Remove runtime NEON detection
2016-05-17 17:56:48 +00:00
transform.c
Fix UBSan errors (left shift of negative value)
2016-05-23 10:28:35 +00:00