fc02a793c2
This reverts commit 299c4e68461f1c4428b2a919913b161115025dff. Reason for revert: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/2753 ../../chrome/browser/media/webrtc/webrtc_browsertest_base.cc(539): error: Expected equality of these values: "ok-got-stats" ExecuteJavascript("verifyLegacyStatsGenerated()", tab) Which is: "Test failed: Error: \"googInterruptionCount\" is not a whitelisted stat. Exposing new metrics in the legacy getStats() API is not allowed. Please follow the standardization process: https://docs.google.com/document/d/1q1CJVUqJ6YW9NNRc0tENkLNny8AHrKZfqjy3SL89zjc/edit?usp=sharing\n at failTest (http://127.0.0.1:50650/webrtc/test_functions.js:46:15)\n at http://127.0.0.1:50650/webrtc/peerconnection.js:481:19" With diff: @@ -1,1 +1,3 @@ -ok-got-stats +Test failed: Error: \"googInterruptionCount\" is not a whitelisted stat. Exposing new metrics in the legacy getStats() API is not allowed. Please follow the standardization process: https://docs.google.com/document/d/1q1CJVUqJ6YW9NNRc0tENkLNny8AHrKZfqjy3SL89zjc/edit?usp=sharing + at failTest (http://127.0.0.1:50650/webrtc/test_functions.js:46:15) + at http://127.0.0.1:50650/webrtc/peerconnection.js:481:19 Original change's description: > Piping audio interruption metrics to API layer > > Bug: webrtc:10549 > Change-Id: Ie6abe5819c5b73dc5f5f89bdc375bad77f44ce97 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134303 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27788} TBR=henrik.lundin@webrtc.org,kwiberg@webrtc.org,ivoc@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:10549 Change-Id: I345306ba9758c0a3b1597724fa860d3e3fdb8995 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134464 Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27802}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.