c0741e9f12
This reverts commit 59f3b35013a29f8c73a46fa6fd06aadc96aad892. Broke WebRTC into Chrome rolls: https://chromium-review.googlesource.com/c/chromium/src/+/5248171?tab=checks /../third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler.cc:216:18: error: no member named 'enable_dtls_srtp' in 'webrtc::PeerConnectionInterface::RTCConfiguration' 216 | configuration->enable_dtls_srtp = dtls_srtp_key_agreement; | ~~~~~~~~~~~~~ ^ Original change's description: > Take out Fuchsia-only SDES-enabling parameters > > This does not remove all traces of SDES - we still need to delete > the cricket::CryptoParams struct and all code that uses it. > > Bug: webrtc:11066, chromium:804275 > Change-Id: I811c8d40da7f4af714d53376f24cd53332a15945 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/336780 > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#41634} Bug: webrtc:11066, chromium:804275 Change-Id: I2c2114873091e0c662977a6ef5723e6447166a65 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/337181 Commit-Queue: Olga Sharonova <olka@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Olga Sharonova <olka@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41643}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.- Avoid structs in api, prefer classes.
The preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.
Avoid defining api with structs as it makes harder for the api to evolve. Your struct may gain invariant, or change how it represents data. Evolving struct from the api is particular challenging as it is designed to be used in other code bases and thus needs to be updated independetly from its usage. Class with accessors and setters makes such migration safer. See Google C++ style guide for more.
If you need to evolve existent struct in api, prefer first to convert it into a class.