c55516dd55
In a future CL, adaptation processing and stream encoder resource management will happen on different task queues. When this is the case, asynchronous tasks will be posted in both directions and some resources will have internal states used on multiple threads. This CL makes the Resource class reference counted in order to support posting tasks to a different threads without risk of use-after-free when a posted task is executed with a delay. This is preferred over WeakPtr strategies because WeakPtrs are single-threaded and preferred over raw pointer usage because the reference counted approach enables more compile-time and run-time assurance. This is also "future proof"; when resources can be injected through public APIs, ownership needs to be shared between libwebrtc and the application (e.g. Chrome). To reduce the risk of making mistakes in the future CL, sequence checkers and task queue DCHECKs are added as well as other DCHECKs to make sure things have been cleaned up before destruction, e.g: - Processor gets a sequence checker. It is entirely single-threaded. - Processor must not have any attached listeners or resources on destruction. - Resources must not have any listeners on destruction. - The Manager, EncodeUsageResource and QualityScalerResource DCHECKs they are running on the encoder queue. - TODOs are added illustrating where we want to add PostTasks in the future CL. Lastly, upon VideoStreamEncoder::Stop() we delete the ResourceAdaptationProcessor. Because the Processor is already used in posted tasks, some if statements are added to ensure the Processor is not used after destruction. Bug: webrtc:11542, webrtc:11520 Change-Id: Ibaa8a61d86d87a71f477d1075a117c28d9d2d285 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174760 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Evan Shrubsole <eshr@google.com> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31217}
73 lines
2.6 KiB
C++
73 lines
2.6 KiB
C++
/*
|
|
* Copyright 2020 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef VIDEO_ADAPTATION_ENCODE_USAGE_RESOURCE_H_
|
|
#define VIDEO_ADAPTATION_ENCODE_USAGE_RESOURCE_H_
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
|
|
#include "absl/types/optional.h"
|
|
#include "api/video/video_adaptation_reason.h"
|
|
#include "call/adaptation/resource.h"
|
|
#include "rtc_base/ref_counted_object.h"
|
|
#include "rtc_base/task_queue.h"
|
|
#include "video/adaptation/overuse_frame_detector.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Handles interaction with the OveruseDetector.
|
|
// TODO(hbos): Add unittests specific to this class, it is currently only tested
|
|
// indirectly by usage in the ResourceAdaptationProcessor (which is only tested
|
|
// because of its usage in VideoStreamEncoder); all tests are currently in
|
|
// video_stream_encoder_unittest.cc.
|
|
class EncodeUsageResource : public rtc::RefCountedObject<Resource>,
|
|
public OveruseFrameDetectorObserverInterface {
|
|
public:
|
|
explicit EncodeUsageResource(
|
|
std::unique_ptr<OveruseFrameDetector> overuse_detector);
|
|
|
|
// TODO(https://crbug.com/webrtc/11542): When we have an adaptation queue,
|
|
// pass it in here.
|
|
void Initialize(rtc::TaskQueue* encoder_queue);
|
|
|
|
bool is_started() const;
|
|
|
|
void StartCheckForOveruse(CpuOveruseOptions options);
|
|
void StopCheckForOveruse();
|
|
|
|
void SetTargetFrameRate(absl::optional<double> target_frame_rate);
|
|
void OnEncodeStarted(const VideoFrame& cropped_frame,
|
|
int64_t time_when_first_seen_us);
|
|
void OnEncodeCompleted(uint32_t timestamp,
|
|
int64_t time_sent_in_us,
|
|
int64_t capture_time_us,
|
|
absl::optional<int> encode_duration_us);
|
|
|
|
// OveruseFrameDetectorObserverInterface implementation.
|
|
void AdaptUp() override;
|
|
void AdaptDown() override;
|
|
|
|
std::string name() const override { return "EncoderUsageResource"; }
|
|
|
|
private:
|
|
int TargetFrameRateAsInt();
|
|
|
|
rtc::TaskQueue* encoder_queue_;
|
|
const std::unique_ptr<OveruseFrameDetector> overuse_detector_
|
|
RTC_GUARDED_BY(encoder_queue_);
|
|
bool is_started_ RTC_GUARDED_BY(encoder_queue_);
|
|
absl::optional<double> target_frame_rate_ RTC_GUARDED_BY(encoder_queue_);
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // VIDEO_ADAPTATION_ENCODE_USAGE_RESOURCE_H_
|