66cadfc0e3
1. It looks like ComPtr cannot work well with vector::emplace_back, I got a consistent crash on one of my machine, but not the other. Move constructor should have no impact to lvalue reference, but I may be wrong here. The impact here is ComPtr released before it should be. So a simple solution is to use copy instead of reference. The D3dDevice is a collection of reference counted pointers (Microsoft::WRL::ComPtr), there is almost no extra cost. 2. Actively set several fields in D3D11_TEXTURE2D_DESC to avoid potential break if there are some platform changes later. 3. AcquireNextFrame returns both a DXGI_OUTDUPL_FRAME_INFO with AccumulatedFrames and an IDXGIResource. But there is no comment in MSDN to ensure IDXGIResource won't be nullptr if AccumulatedFrames > 0. Adding an extra check in DxgiOutputDuplicator makes it a safer. BUG=314516 Review-Url: https://codereview.webrtc.org/2345163002 Cr-Commit-Position: refs/heads/master@{#14341}
58 lines
1.7 KiB
C++
58 lines
1.7 KiB
C++
/*
|
|
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_MODULES_DESKTOP_CAPTURE_WIN_D3D_DEVICE_H_
|
|
#define WEBRTC_MODULES_DESKTOP_CAPTURE_WIN_D3D_DEVICE_H_
|
|
|
|
#include <comdef.h>
|
|
#include <wrl/client.h>
|
|
#include <D3D11.h>
|
|
#include <DXGI.h>
|
|
|
|
#include <vector>
|
|
|
|
namespace webrtc {
|
|
|
|
// A wrapper of ID3D11Device and its corresponding context and IDXGIAdapter.
|
|
// This class represents one video card in the system.
|
|
class D3dDevice {
|
|
public:
|
|
~D3dDevice();
|
|
|
|
ID3D11Device* d3d_device() const { return d3d_device_.Get(); }
|
|
|
|
ID3D11DeviceContext* context() const { return context_.Get(); }
|
|
|
|
IDXGIDevice* dxgi_device() const { return dxgi_device_.Get(); }
|
|
|
|
IDXGIAdapter* dxgi_adapter() const { return dxgi_adapter_.Get(); }
|
|
|
|
// Returns all D3dDevice instances on the system. Returns an empty vector if
|
|
// anything wrong.
|
|
static std::vector<D3dDevice> EnumDevices();
|
|
|
|
private:
|
|
// Instances of D3dDevice should only be created by EnumDevices() static
|
|
// function.
|
|
D3dDevice();
|
|
|
|
// Initializes the D3dDevice from an IDXGIAdapter.
|
|
bool Initialize(const Microsoft::WRL::ComPtr<IDXGIAdapter>& adapter);
|
|
|
|
Microsoft::WRL::ComPtr<ID3D11Device> d3d_device_;
|
|
Microsoft::WRL::ComPtr<ID3D11DeviceContext> context_;
|
|
Microsoft::WRL::ComPtr<IDXGIDevice> dxgi_device_;
|
|
Microsoft::WRL::ComPtr<IDXGIAdapter> dxgi_adapter_;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // WEBRTC_MODULES_DESKTOP_CAPTURE_WIN_D3D_DEVICE_H_
|