0182f85fd1
Previously AlrDetector was measuring amount of data sent in each 100ms interval and would enter ALR mode after 5 consecutive intervals when average bandwidth usage doesn't exceed 30% of the current estimate estimate. This meant that an application that uses only slightely more than 6% of total bandwidth may stay out of ALR mode, e.g. if it sends a frame of size BW*30ms every 0.5 seconds. 100ms is too short interval to average over, particularly when frame-rate falls below 10fps. With this change AlrDetector averages BW usage over last 500ms. It then enters ALR state when usage falls below 30% and exits it when usage exceeds 50%. BUG=webrtc:6332 R=philipel@webrtc.org, stefan@webrtc.org Review URL: https://codereview.webrtc.org/2503643003 . Cr-Commit-Position: refs/heads/master@{#15109}
50 lines
1.5 KiB
C++
50 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_MODULES_PACING_ALR_DETECTOR_H_
|
|
#define WEBRTC_MODULES_PACING_ALR_DETECTOR_H_
|
|
|
|
#include "webrtc/base/rate_statistics.h"
|
|
#include "webrtc/common_types.h"
|
|
#include "webrtc/modules/pacing/paced_sender.h"
|
|
#include "webrtc/typedefs.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Application limited region detector is a class that utilizes signals of
|
|
// elapsed time and bytes sent to estimate whether network traffic is
|
|
// currently limited by the application's ability to generate traffic.
|
|
//
|
|
// AlrDetector provides a signal that can be utilized to adjust
|
|
// estimate bandwidth.
|
|
// Note: This class is not thread-safe.
|
|
class AlrDetector {
|
|
public:
|
|
AlrDetector();
|
|
~AlrDetector();
|
|
|
|
void OnBytesSent(size_t bytes_sent, int64_t now_ms);
|
|
|
|
// Set current estimated bandwidth.
|
|
void SetEstimatedBitrate(int bitrate_bps);
|
|
|
|
// Returns true if currently in application-limited region.
|
|
bool InApplicationLimitedRegion() const;
|
|
|
|
private:
|
|
RateStatistics rate_;
|
|
int estimated_bitrate_bps_ = 0;
|
|
bool application_limited_ = false;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // WEBRTC_MODULES_PACING_ALR_DETECTOR_H_
|