Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
63 lines
1.4 KiB
C++
63 lines
1.4 KiB
C++
/*
|
|
* Copyright 2004 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_BASE_TASKPARENT_H__
|
|
#define WEBRTC_BASE_TASKPARENT_H__
|
|
|
|
#include <set>
|
|
|
|
#include "webrtc/base/basictypes.h"
|
|
#include "webrtc/base/scoped_ptr.h"
|
|
|
|
namespace rtc {
|
|
|
|
class Task;
|
|
class TaskRunner;
|
|
|
|
class TaskParent {
|
|
public:
|
|
TaskParent(Task *derived_instance, TaskParent *parent);
|
|
explicit TaskParent(TaskRunner *derived_instance);
|
|
virtual ~TaskParent();
|
|
|
|
TaskParent *GetParent() { return parent_; }
|
|
TaskRunner *GetRunner() { return runner_; }
|
|
|
|
bool AllChildrenDone();
|
|
bool AnyChildError();
|
|
#ifdef _DEBUG
|
|
bool IsChildTask(Task *task);
|
|
#endif
|
|
|
|
protected:
|
|
void OnStopped(Task *task);
|
|
void AbortAllChildren();
|
|
TaskParent *parent() {
|
|
return parent_;
|
|
}
|
|
|
|
private:
|
|
void Initialize();
|
|
void OnChildStopped(Task *child);
|
|
void AddChild(Task *child);
|
|
|
|
TaskParent *parent_;
|
|
TaskRunner *runner_;
|
|
bool child_error_;
|
|
typedef std::set<Task *> ChildSet;
|
|
scoped_ptr<ChildSet> children_;
|
|
DISALLOW_EVIL_CONSTRUCTORS(TaskParent);
|
|
};
|
|
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // WEBRTC_BASE_TASKPARENT_H__
|