b4ff7a7a8b
Reason for revert: Alas, the bot magically fails again. Looks like indeed it's a Clang bug :( https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28Clang%29/builds/1687 Original issue's description: > Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK. (patchset #1 id:1 of https://codereview.webrtc.org/2006313009/ ) > > Reason for revert: > Relanding. The errors look like legit disk space problems so I'm going to watch the bots this time. > > Original issue's description: > > Revert of Adding a some checks and switching out a few assert for RTC_[D]CHECK. (patchset #1 id:1 of https://codereview.webrtc.org/2009253004/ ) > > > > Reason for revert: > > Fails unexpectedly on multiple commit bots: > > https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug%20%28Clang%29/builds/1748 > > https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28Clang%29/builds/1683 > > > > I filed https://bugs.chromium.org/p/chromium/issues/detail?id=614967 to track the problem. I'll reland if it doesn't solve the problem. > > > > Original issue's description: > > > Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK. (patchset #1 id:1 of https://codereview.webrtc.org/2006243002/ ) > > > > > > Original issue's description: > > > > Adding a some checks and switching out a few assert for RTC_[D]CHECK. > > > > These changes are around use of AudioFrame.data_ to help us catch issues earlier since assert() is left out in release builds, including builds with DCHECK enabled. I've also added a few full-on CHECKs to avoid reading past buffer boundaries or continuing on in a failed state. > > > > > > > > BUG=chromium:613482 > > > > NOTRY=true > > > > (using notry due to offline android_arm64_rel bot) > > > > > > > > Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b > > > > Cr-Commit-Position: refs/heads/master@{#12870} > > > > > > TBR=henrik.lundin@webrtc.org > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > BUG=chromium:613482 > > > > > > Committed: https://crrev.com/ba189cc4f4f6fe311a815646059e8011ffa53894 > > > Cr-Commit-Position: refs/heads/master@{#12907} > > > > TBR=henrik.lundin@webrtc.org,tommi@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=chromium:613482 > > > > Committed: https://crrev.com/6895d8ca788df29f4d3a4b97fe891f0fb3a6dbec > > Cr-Commit-Position: refs/heads/master@{#12909} > > TBR=henrik.lundin@webrtc.org,kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:613482 > > Committed: https://crrev.com/b7318f1293453d8d319e27473c5bfb72292ebfd2 > Cr-Commit-Position: refs/heads/master@{#12920} TBR=henrik.lundin@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:613482 Review-Url: https://codereview.webrtc.org/2018553002 Cr-Commit-Position: refs/heads/master@{#12921}
29 lines
1.1 KiB
C++
29 lines
1.1 KiB
C++
/*
|
|
* Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
#include "webrtc/common_audio/resampler/include/push_resampler.h"
|
|
|
|
// Quality testing of PushResampler is handled through output_mixer_unittest.cc.
|
|
|
|
namespace webrtc {
|
|
|
|
TEST(PushResamplerTest, VerifiesInputParameters) {
|
|
PushResampler<int16_t> resampler;
|
|
EXPECT_EQ(-1, resampler.InitializeIfNeeded(-1, 16000, 1));
|
|
EXPECT_EQ(-1, resampler.InitializeIfNeeded(16000, -1, 1));
|
|
EXPECT_EQ(-1, resampler.InitializeIfNeeded(16000, 16000, 0));
|
|
EXPECT_EQ(-1, resampler.InitializeIfNeeded(16000, 16000, 3));
|
|
EXPECT_EQ(0, resampler.InitializeIfNeeded(16000, 16000, 1));
|
|
EXPECT_EQ(0, resampler.InitializeIfNeeded(16000, 16000, 2));
|
|
}
|
|
|
|
} // namespace webrtc
|