Taylor Brandstetter
d0acbd8645
Revert "Do all BaseChannel operations within a single Thread::Invoke."
...
This reverts commit c1ad1ff178f0d0dfcde42843c51ae703005aaca1.
Reason for revert: This blocks the worker thread for a longer
contiguous period of time which can lead to delays in processing
packets. And due to other recent changes, the need to speed up
SetLocalDescription/SetRemoteDescription is reduced.
Still plan to reland some of the changes from the CL, just not the
part that groups the Invokes.
Original change's description:
> Do all BaseChannel operations within a single Thread::Invoke.
>
> Instead of doing a separate Invoke for each channel, this CL first
> gathers a list of operations to be performed on the signaling thread,
> then does a single Invoke on the worker thread (and nested Invoke
> on the network thread) to update all channels at once.
>
> This includes the methods:
> * Enable
> * SetLocalContent/SetRemoteContent
> * RegisterRtpDemuxerSink
> * UpdateRtpHeaderExtensionMap
>
> Also, removed the need for a network thread Invoke in
> IsReadyToSendMedia_w by moving ownership of was_ever_writable_ to the
> worker thread.
>
> Bug: webrtc:12266
> Change-Id: I31e61fe0758aeb053b09db84f234deb58dfb3d05
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194181
> Commit-Queue: Taylor <deadbeef@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32817}
TBR=deadbeef@webrtc.org ,hta@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:12266
Change-Id: I40ec519a614dc740133219f775b5638a488529b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/203860
Reviewed-by: Taylor <deadbeef@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Taylor <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33111}
2021-01-29 21:56:38 +00:00
..
2020-11-24 09:19:54 +00:00
2021-01-29 21:56:38 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-09-10 13:11:44 +00:00
2020-10-12 07:28:01 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 21:56:38 +00:00
2020-06-17 08:41:14 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 21:56:38 +00:00
2021-01-29 21:56:38 +00:00
2021-01-29 21:56:38 +00:00
2020-03-20 16:55:38 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-20 10:51:07 +00:00
2020-11-04 11:10:53 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-11 11:31:33 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2019-01-28 11:17:00 +00:00
2020-03-21 18:53:46 +00:00
2019-07-08 13:45:15 +00:00
2021-01-29 16:14:10 +00:00
2020-03-21 18:53:46 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-01-22 20:46:52 +00:00
2020-01-22 20:46:52 +00:00
2021-01-29 16:14:10 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2020-11-27 11:08:10 +00:00
2021-01-29 16:14:10 +00:00
2019-04-02 10:13:36 +00:00
2019-09-17 15:47:29 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2019-04-18 19:11:31 +00:00
2019-04-18 19:11:31 +00:00
2019-07-08 13:45:15 +00:00
2021-01-29 16:14:10 +00:00
2019-04-18 19:11:31 +00:00
2021-01-05 12:55:24 +00:00
2021-01-05 12:55:24 +00:00
2021-01-05 12:55:24 +00:00
2021-01-28 09:41:08 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-06-17 08:41:14 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-25 20:29:58 +00:00
2021-01-29 16:14:10 +00:00
2019-05-13 18:37:47 +00:00
2021-01-19 14:28:11 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2019-01-29 02:33:50 +00:00
2019-01-25 20:29:58 +00:00
2020-05-18 17:06:25 +00:00
2019-07-08 13:45:15 +00:00
2020-09-10 13:11:44 +00:00
2020-02-25 14:45:04 +00:00
2020-06-11 14:17:01 +00:00
2021-01-20 10:51:07 +00:00
2020-05-12 14:43:43 +00:00
2020-09-01 12:17:00 +00:00
2021-01-20 10:51:07 +00:00
2019-07-08 13:45:15 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-12-17 23:43:42 +00:00
2021-01-20 10:51:07 +00:00
2020-08-25 09:56:39 +00:00
2021-01-22 13:18:05 +00:00
2021-01-26 09:52:14 +00:00
2020-08-05 22:34:46 +00:00
2020-09-24 08:03:50 +00:00
2020-08-11 10:46:23 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-09-11 14:11:27 +00:00
2021-01-20 10:51:07 +00:00
2020-10-21 08:20:05 +00:00
2020-08-11 10:46:23 +00:00
2020-07-29 11:27:43 +00:00
2019-10-14 12:40:53 +00:00
2021-01-29 16:14:10 +00:00
2021-01-28 14:22:52 +00:00
2020-05-18 17:06:25 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-11-17 12:34:39 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-20 10:51:07 +00:00
2019-04-09 17:18:20 +00:00
2020-11-17 12:34:39 +00:00
2019-01-25 20:29:58 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2020-07-10 00:03:21 +00:00
2021-01-29 16:14:10 +00:00
2019-07-08 13:45:15 +00:00
2020-08-11 10:46:23 +00:00
2021-01-29 16:14:10 +00:00
2020-01-09 09:28:07 +00:00
2021-01-29 16:14:10 +00:00
2020-01-09 09:28:07 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-06-17 08:41:14 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-14 17:46:25 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-11-10 14:41:45 +00:00
2021-01-29 16:14:10 +00:00
2019-05-24 23:58:46 +00:00
2020-03-20 16:55:38 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-09-21 08:12:50 +00:00
2021-01-29 16:14:10 +00:00
2019-11-16 14:56:01 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-11 11:31:33 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 21:56:38 +00:00
2021-01-29 21:56:38 +00:00
2019-07-08 13:45:15 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-10-26 10:22:46 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-19 14:28:11 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2019-07-08 13:45:15 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-07-16 13:52:28 +00:00
2020-12-04 15:33:06 +00:00
2020-12-04 15:33:06 +00:00
2019-09-17 15:47:29 +00:00
2021-01-29 16:14:10 +00:00
2019-07-08 13:45:15 +00:00
2020-10-05 12:41:23 +00:00
2020-10-12 07:28:01 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2019-01-11 17:11:39 +00:00
2020-05-17 17:15:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2019-02-05 15:12:20 +00:00
2019-10-28 11:30:23 +00:00
2020-10-09 08:29:45 +00:00
2021-01-29 16:14:10 +00:00
2019-09-24 08:56:24 +00:00
2019-06-24 08:50:07 +00:00
2020-05-18 17:06:25 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-05-18 17:06:25 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2019-07-08 13:45:15 +00:00
2021-01-29 16:14:10 +00:00
2019-07-08 13:45:15 +00:00
2021-01-29 16:14:10 +00:00
2020-10-12 07:28:01 +00:00
2021-01-29 10:54:00 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-11-09 16:13:15 +00:00
2021-01-29 16:14:10 +00:00