aeb8ce882f
This change enables the use of two different adaptation speeds of the matched filter of the delay estimator of AEC3. One speed is used when no delay has been found, and one is used after a reliable delay has been found. The purpose is to use a slower adaptation speed to reduce the risk of divergence during double-talk without slowing down the search for the initial delay. The CL prepares for experimentation by adding field trials for controlling the two adaptation speeds. Bug: webrtc:12775 Change-Id: I817a1ab5ded0f78d20de45edcf04c708290173fc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219083 Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34055}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.