a77e16ca2c
Specifically, use reference instead of pointer for out parameter and place the out parameter last, for the following methods ReadUInt8 ReadUInt16 ReadUInt32 ReadBits PeekBits ReadNonSymmetric ReadSignedExponentialGolomb ReadExponentialGolomb Bug: webrtc:11933 Change-Id: I3f1efe3e29155985277b0cd18700ddea25fe7914 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218504 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34037}
82 lines
2.2 KiB
C++
82 lines
2.2 KiB
C++
/*
|
|
* Copyright (c) 2018 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "logging/rtc_event_log/encoder/var_int.h"
|
|
|
|
#include "rtc_base/checks.h"
|
|
|
|
// TODO(eladalon): Add unit tests.
|
|
|
|
namespace webrtc {
|
|
|
|
const size_t kMaxVarIntLengthBytes = 10; // ceil(64 / 7.0) is 10.
|
|
|
|
std::string EncodeVarInt(uint64_t input) {
|
|
std::string output;
|
|
output.reserve(kMaxVarIntLengthBytes);
|
|
|
|
do {
|
|
uint8_t byte = static_cast<uint8_t>(input & 0x7f);
|
|
input >>= 7;
|
|
if (input > 0) {
|
|
byte |= 0x80;
|
|
}
|
|
output += byte;
|
|
} while (input > 0);
|
|
|
|
RTC_DCHECK_GE(output.size(), 1u);
|
|
RTC_DCHECK_LE(output.size(), kMaxVarIntLengthBytes);
|
|
|
|
return output;
|
|
}
|
|
|
|
// There is some code duplication between the flavors of this function.
|
|
// For performance's sake, it's best to just keep it.
|
|
std::pair<bool, absl::string_view> DecodeVarInt(absl::string_view input,
|
|
uint64_t* output) {
|
|
RTC_DCHECK(output);
|
|
|
|
uint64_t decoded = 0;
|
|
for (size_t i = 0; i < input.length() && i < kMaxVarIntLengthBytes; ++i) {
|
|
decoded += (static_cast<uint64_t>(input[i] & 0x7f)
|
|
<< static_cast<uint64_t>(7 * i));
|
|
if (!(input[i] & 0x80)) {
|
|
*output = decoded;
|
|
return {true, input.substr(i + 1)};
|
|
}
|
|
}
|
|
|
|
return {false, input};
|
|
}
|
|
|
|
// There is some code duplication between the flavors of this function.
|
|
// For performance's sake, it's best to just keep it.
|
|
size_t DecodeVarInt(rtc::BitBuffer* input, uint64_t* output) {
|
|
RTC_DCHECK(output);
|
|
|
|
uint64_t decoded = 0;
|
|
for (size_t i = 0; i < kMaxVarIntLengthBytes; ++i) {
|
|
uint8_t byte;
|
|
if (!input->ReadUInt8(byte)) {
|
|
return 0;
|
|
}
|
|
decoded +=
|
|
(static_cast<uint64_t>(byte & 0x7f) << static_cast<uint64_t>(7 * i));
|
|
if (!(byte & 0x80)) {
|
|
*output = decoded;
|
|
return i + 1;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
} // namespace webrtc
|