99261af5a4
This reverts commit 3ce6391b38397d107478041299fa998500e4fc42. Reason for revert: Breaks downstream test Original change's description: > Define cricket::MediaType in terms of webrtc::MediaType > > This is one step in getting rid of cricket::MediaType. > > Bug: webrtc:12754 > Fixes: webrtc:12764 > Change-Id: Idee832572bdc4c0e3bfdec6fb31ec0ba9db3e995 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218346 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#33994} TBR=mbonadei@webrtc.org,hta@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I64772018dea55e4f0946464364a60a39cec7e9ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:12754 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218603 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34000}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.