1f3679884c
Start introducing ArrayView to AudioFrame and code that flows down from there. In this first step: * Add `data_view()` that returns a read-only ArrayView for the audio buffer. When AudioFrame is not initialized however, data_view() will return a nullptr whereas the current data() method never returns nullptr. * Add `mutable_data()` that requires two arguments for properly setting the samples per channel and number of channels that's required for accurately reserving the returned mutable ArrayView. A notable behavior change is that if the requested number of channels is larger than supported or the calculated buffer size is too large, the function will trigger a check. * Add TODOs for following work. Bug: chromium:335805780 Change-Id: I2937de800422589ebe6a3840b3caadf3d9ff8b00 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347982 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42202}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.- Avoid structs in api, prefer classes.
The preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.
Avoid defining api with structs as it makes harder for the api to evolve. Your struct may gain invariant, or change how it represents data. Evolving struct from the api is particular challenging as it is designed to be used in other code bases and thus needs to be updated independetly from its usage. Class with accessors and setters makes such migration safer. See Google C++ style guide for more.
If you need to evolve existent struct in api, prefer first to convert it into a class.