Karl Wiberg
ac025898e1
Fix misunderstanding: OnTransportChanged is called on network thread
...
Earlier CLs assumed that the object pointed to by call_ had to be
accessed on the worker thread. While this is generally the case,
Call::MediaTransportChange is explicitly thread safe, so
PeerConnection::OnTransportChanged doesn't have to run on the worker
thread for that reason.
Which is fortunate, because it actually runs on the network thread.
The RTC_RUN_ON(worker_thread()) annotation on the method declaration
was ineffective because this method is being called via a base class
pointer; replacing it with a call to
RTC_DCHECK_RUN_ON(worker_thread()) in the function body immediately
triggered assertions in the unit tests.
Bug: webrtc:9987
Change-Id: I08cf558a74f4ca2b2eff8ef4810ebbd1287a9726
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129442
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27287}
2019-03-26 12:51:34 +00:00
..
2019-03-06 18:44:35 +00:00
2019-02-11 12:47:51 +00:00
2019-02-11 12:47:51 +00:00
2019-01-11 17:11:39 +00:00
2019-01-25 20:29:58 +00:00
2019-03-21 15:23:05 +00:00
2019-01-28 18:56:02 +00:00
2019-02-26 18:32:22 +00:00
2019-02-21 13:20:53 +00:00
2019-01-28 18:56:02 +00:00
2019-02-01 15:02:36 +00:00
2019-03-19 16:48:47 +00:00
2019-01-28 18:56:02 +00:00
2019-03-11 13:21:36 +00:00
2019-03-11 13:21:36 +00:00
2019-03-11 13:21:36 +00:00
2019-01-28 11:17:00 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-02-27 18:55:15 +00:00
2019-02-21 16:38:37 +00:00
2019-02-21 16:38:37 +00:00
2019-01-11 17:11:39 +00:00
2019-01-15 13:15:58 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-03-19 08:13:13 +00:00
2019-03-19 08:13:13 +00:00
2019-01-11 17:11:39 +00:00
2019-01-30 16:16:51 +00:00
2019-01-30 16:16:51 +00:00
2019-01-30 16:16:51 +00:00
2019-01-11 17:11:39 +00:00
2019-02-08 22:51:37 +00:00
2019-02-08 22:51:37 +00:00
2019-03-01 20:32:16 +00:00
2019-03-11 08:04:09 +00:00
2019-03-11 08:04:09 +00:00
2019-01-31 13:23:33 +00:00
2019-03-12 23:49:57 +00:00
2019-01-17 10:21:32 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-25 20:29:58 +00:00
2019-03-11 10:15:52 +00:00
2019-03-11 10:15:52 +00:00
2019-03-01 20:32:16 +00:00
2019-01-29 02:33:50 +00:00
2019-01-25 20:29:58 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-25 20:29:58 +00:00
2019-03-22 16:47:56 +00:00
2019-01-31 13:23:33 +00:00
2019-01-31 13:23:33 +00:00
2019-03-01 20:32:16 +00:00
2019-02-12 12:27:04 +00:00
2019-03-19 08:13:13 +00:00
2019-03-19 19:37:15 +00:00
2019-03-19 19:37:15 +00:00
2019-03-19 19:37:15 +00:00
2019-03-05 22:49:48 +00:00
2019-03-04 13:56:53 +00:00
2019-03-19 19:37:15 +00:00
2019-01-11 17:11:39 +00:00
2019-03-19 19:37:15 +00:00
2019-01-31 13:23:33 +00:00
2019-01-25 20:29:58 +00:00
2019-03-05 17:51:14 +00:00
2019-01-31 13:23:33 +00:00
2019-03-05 22:01:34 +00:00
2019-03-21 15:23:05 +00:00
2019-03-21 15:23:05 +00:00
2019-03-26 12:51:34 +00:00
2019-03-26 12:51:34 +00:00
2019-02-27 15:08:34 +00:00
2019-02-27 15:08:34 +00:00
2019-02-27 15:08:34 +00:00
2019-02-27 15:08:34 +00:00
2019-02-27 15:08:34 +00:00
2019-01-11 17:11:39 +00:00
2019-02-27 15:08:34 +00:00
2019-02-27 15:08:34 +00:00
2019-03-06 16:35:16 +00:00
2019-03-06 16:35:16 +00:00
2019-02-28 12:38:30 +00:00
2019-03-06 16:35:16 +00:00
2019-01-29 09:45:21 +00:00
2019-01-11 17:11:39 +00:00
2019-01-25 20:29:58 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-31 13:23:33 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-29 02:33:50 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-02-11 12:47:51 +00:00
2019-02-11 12:47:51 +00:00
2019-02-27 15:08:34 +00:00
2019-02-27 01:46:50 +00:00
2019-02-27 01:46:50 +00:00
2019-01-11 17:11:39 +00:00
2019-01-29 02:33:50 +00:00
2019-02-20 16:02:59 +00:00
2019-01-11 17:11:39 +00:00
2019-03-11 14:47:15 +00:00
2019-03-25 08:52:45 +00:00
2019-03-25 08:52:45 +00:00
2019-02-28 10:15:05 +00:00
2019-02-28 10:15:05 +00:00
2019-02-28 10:15:05 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-31 13:23:33 +00:00
2019-01-29 02:33:50 +00:00
2019-01-11 17:11:39 +00:00
2019-03-20 06:10:31 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-29 02:33:50 +00:00
2019-02-27 21:00:58 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-03-05 22:49:48 +00:00
2019-01-11 17:11:39 +00:00
2019-01-25 20:29:58 +00:00
2019-01-31 13:23:33 +00:00
2019-03-19 16:48:47 +00:00
2019-03-19 16:48:47 +00:00
2019-01-31 13:23:33 +00:00
2019-03-22 17:26:20 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-28 09:53:50 +00:00
2019-01-11 17:11:39 +00:00
2019-02-05 15:12:20 +00:00
2019-02-05 15:12:20 +00:00
2019-02-27 15:08:34 +00:00
2019-02-27 15:08:34 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-21 07:33:35 +00:00
2019-01-11 17:11:39 +00:00
2019-01-25 20:29:58 +00:00
2019-03-01 20:32:16 +00:00
2019-03-01 20:32:16 +00:00
2019-01-25 13:58:57 +00:00
2019-01-29 02:33:50 +00:00
2019-01-28 18:56:02 +00:00