ab009c27b4
This change refactors existing self-assignments within if clauses across the WebRTC codebase. *Why:* - Bug Prevention: Assignments within conditionals are frequently unintended errors, often mistaken for equality checks. - Clearer Code: Separating assignments from conditionals improves code readability and reduces the risk of misinterpretation. Change-Id: I199dc26a35ceca109a2ac569b446811314dfdf0b Bug: chromium:361594695 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360460 Reviewed-by: Chuck Hays <haysc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42850}
88 lines
3.1 KiB
Objective-C
88 lines
3.1 KiB
Objective-C
/*
|
|
* Copyright 2014 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import "ARDTURNClient+Internal.h"
|
|
|
|
#import "ARDUtilities.h"
|
|
#import "RTCIceServer+JSON.h"
|
|
|
|
// TODO(tkchin): move this to a configuration object.
|
|
static NSString *kTURNRefererURLString = @"https://appr.tc";
|
|
static NSString *kARDTURNClientErrorDomain = @"ARDTURNClient";
|
|
static NSInteger kARDTURNClientErrorBadResponse = -1;
|
|
|
|
@implementation ARDTURNClient {
|
|
NSURL *_url;
|
|
}
|
|
|
|
- (instancetype)initWithURL:(NSURL *)url {
|
|
NSParameterAssert([url absoluteString].length);
|
|
self = [super init];
|
|
if (self) {
|
|
_url = url;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (void)requestServersWithCompletionHandler:
|
|
(void (^)(NSArray *turnServers, NSError *error))completionHandler {
|
|
|
|
NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:_url];
|
|
[NSURLConnection sendAsyncRequest:request
|
|
completionHandler:^(NSURLResponse *response, NSData *data, NSError *error) {
|
|
if (error) {
|
|
completionHandler(nil, error);
|
|
return;
|
|
}
|
|
NSDictionary *responseDict = [NSDictionary dictionaryWithJSONData:data];
|
|
NSString *iceServerUrl = responseDict[@"ice_server_url"];
|
|
[self makeTurnServerRequestToURL:[NSURL URLWithString:iceServerUrl]
|
|
WithCompletionHandler:completionHandler];
|
|
}];
|
|
}
|
|
|
|
#pragma mark - Private
|
|
|
|
- (void)makeTurnServerRequestToURL:(NSURL *)url
|
|
WithCompletionHandler:(void (^)(NSArray *turnServers,
|
|
NSError *error))completionHandler {
|
|
NSMutableURLRequest *iceServerRequest = [NSMutableURLRequest requestWithURL:url];
|
|
iceServerRequest.HTTPMethod = @"POST";
|
|
[iceServerRequest addValue:kTURNRefererURLString forHTTPHeaderField:@"referer"];
|
|
[NSURLConnection sendAsyncRequest:iceServerRequest
|
|
completionHandler:^(NSURLResponse *response,
|
|
NSData *data,
|
|
NSError *error) {
|
|
if (error) {
|
|
completionHandler(nil, error);
|
|
return;
|
|
}
|
|
NSDictionary *turnResponseDict = [NSDictionary dictionaryWithJSONData:data];
|
|
NSMutableArray *turnServers = [NSMutableArray array];
|
|
[turnResponseDict[@"iceServers"]
|
|
enumerateObjectsUsingBlock:^(NSDictionary *obj, NSUInteger idx, BOOL *stop) {
|
|
[turnServers addObject:[RTC_OBJC_TYPE(RTCIceServer) serverFromJSONDictionary:obj]];
|
|
}];
|
|
if (!turnServers) {
|
|
NSError *responseError =
|
|
[[NSError alloc] initWithDomain:kARDTURNClientErrorDomain
|
|
code:kARDTURNClientErrorBadResponse
|
|
userInfo:@{
|
|
NSLocalizedDescriptionKey: @"Bad TURN response.",
|
|
}];
|
|
completionHandler(nil, responseError);
|
|
return;
|
|
}
|
|
completionHandler(turnServers, nil);
|
|
}];
|
|
}
|
|
|
|
@end
|