a7d8f19a77
Some NaCl system headers live in a special directory and the toolchain doesn't propagate the -I compiler flag [2]. A common workaround in Chromium is to use 'public_deps' in order to propagate //native_client_sdk/src/libraries/nacl_io:nacl_io_include_dirs one step further in the build graph. [1] - https://cs.chromium.org/chromium/src/native_client_sdk/src/libraries/nacl_io/ [2] - -Inative_client_sdk/src/libraries/third_party/newlib-extras Bug: chromium:925028 Change-Id: I5145b80c2ae6969f79fcbfcf93a6b05c8a122746 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129701 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27373}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.