a736f30a5f
If configured, attempt to negotiate "zero checksum acceptable" capability, which will make the outgoing packets have a fixed checksum of zero. Received packets will not be verified for a correct checksum if it's zero. Also includes some boilerplate: - Setting capability in state cookie - Adding capability to handover state - Adding metric to know if the feature is used This feature is not enabled by default, as it will be first evaluated with an A/B experiment before making it the default. When the feature is enabled, lower CPU consumption for both receiving and sending packets is expected. How much depends on the architecture, as some architectures have better support for generating CRC32 in hardware than others. Bug: webrtc:14997 Change-Id: If23f73e87220c7d42bd4f9a92772cda16bc18fcb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299076 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39920}
62 lines
2.6 KiB
C++
62 lines
2.6 KiB
C++
/*
|
|
* Copyright (c) 2021 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#include "net/dcsctp/socket/state_cookie.h"
|
|
|
|
#include "net/dcsctp/testing/testing_macros.h"
|
|
#include "rtc_base/gunit.h"
|
|
#include "test/gmock.h"
|
|
|
|
namespace dcsctp {
|
|
namespace {
|
|
using ::testing::SizeIs;
|
|
|
|
TEST(StateCookieTest, SerializeAndDeserialize) {
|
|
Capabilities capabilities = {.partial_reliability = true,
|
|
.message_interleaving = false,
|
|
.reconfig = true,
|
|
.zero_checksum = true,
|
|
.negotiated_maximum_incoming_streams = 123,
|
|
.negotiated_maximum_outgoing_streams = 234};
|
|
StateCookie cookie(VerificationTag(123), TSN(456),
|
|
/*a_rwnd=*/789, TieTag(101112), capabilities);
|
|
std::vector<uint8_t> serialized = cookie.Serialize();
|
|
EXPECT_THAT(serialized, SizeIs(StateCookie::kCookieSize));
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(StateCookie deserialized,
|
|
StateCookie::Deserialize(serialized));
|
|
EXPECT_EQ(deserialized.initiate_tag(), VerificationTag(123));
|
|
EXPECT_EQ(deserialized.initial_tsn(), TSN(456));
|
|
EXPECT_EQ(deserialized.a_rwnd(), 789u);
|
|
EXPECT_EQ(deserialized.tie_tag(), TieTag(101112));
|
|
EXPECT_TRUE(deserialized.capabilities().partial_reliability);
|
|
EXPECT_FALSE(deserialized.capabilities().message_interleaving);
|
|
EXPECT_TRUE(deserialized.capabilities().reconfig);
|
|
EXPECT_TRUE(deserialized.capabilities().zero_checksum);
|
|
EXPECT_EQ(deserialized.capabilities().negotiated_maximum_incoming_streams,
|
|
123);
|
|
EXPECT_EQ(deserialized.capabilities().negotiated_maximum_outgoing_streams,
|
|
234);
|
|
}
|
|
|
|
TEST(StateCookieTest, ValidateMagicValue) {
|
|
Capabilities capabilities = {.partial_reliability = true,
|
|
.message_interleaving = false,
|
|
.reconfig = true};
|
|
StateCookie cookie(VerificationTag(123), TSN(456),
|
|
/*a_rwnd=*/789, TieTag(101112), capabilities);
|
|
std::vector<uint8_t> serialized = cookie.Serialize();
|
|
ASSERT_THAT(serialized, SizeIs(StateCookie::kCookieSize));
|
|
|
|
absl::string_view magic(reinterpret_cast<const char*>(serialized.data()), 8);
|
|
EXPECT_EQ(magic, "dcSCTP00");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace dcsctp
|