cfaba8fd2d
by storing [[LastCreatedOffer]] / [[LastCreatedAnswer]] which are similar to the W3C equivalent but as description objects instead of serialized SDP strings. While rejecting all SDP munging is not feasible, this lets us measure and reject certain modifications gradually. Chromium metrics CL: https://chromium-review.googlesource.com/c/chromium/src/+/6089633 This is measured at three points during the lifetime of a peerconnection: * for the first SLD call * when the connection is first established * when the connection was established and is being closed Note that the "first" SDP munging detected is returned which may hide that something uses more than one modification. BUG=chromium:40567530 Change-Id: I964e3ee6e75f73b777d90556fac8691a6f3dc27f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/370680 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Johannes Kron <kron@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43741}
26 lines
807 B
C++
26 lines
807 B
C++
/*
|
|
* Copyright 2025 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef PC_SDP_MUNGING_DETECTOR_H_
|
|
#define PC_SDP_MUNGING_DETECTOR_H_
|
|
|
|
#include "api/jsep.h"
|
|
#include "api/uma_metrics.h"
|
|
|
|
namespace webrtc {
|
|
// Determines if and how the SDP was modified.
|
|
SdpMungingType DetermineSdpMungingType(
|
|
const SessionDescriptionInterface* sdesc,
|
|
const SessionDescriptionInterface* last_created_desc);
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // PC_SDP_MUNGING_DETECTOR_H_
|