9b35da880b
This reverts commit fb6f975401972635a644c0db06c135b4c0aaef4a. Reason for revert: Looks like this breaks chromium.webrtc.fyi: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Mac%20Tester/6000 https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/6209 https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win7%20Tester/6177 https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win8%20Tester/6299 Original change's description: > Implement packets_(sent | received) for RTCTransportStats > > Bug: webrtc:11756 > Change-Id: Ic0caad6d4675969ef3ae886f50326e4a2e1cbfe7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178741 > Reviewed-by: Tommi <tommi@webrtc.org> > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Commit-Queue: Artem Titov <titovartem@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31643} TBR=hbos@webrtc.org,tommi@webrtc.org,titovartem@webrtc.org Change-Id: Icbb0974ba29cbddb614f1f37f8a2de1a7c56b571 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:11756 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178868 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31665}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.