a013a02e01
Essentially a copy of https://codereview.chromium.org/2299953002/ plus changes to WebRTC's license, changed OWNERS and additional MB updates up to Chromium revision http://crrev.com/f1e2718a3ff. The PRESUBMIT.py check was updated to use the existing webrtc/build/mb_config.pyl to avoid breaking bots (that have this path hardcoded). This replaces the previously symlinked MB, which already runs validation of the WebRTC configs as part of webrtc/build/PRESUBMIT.py. BUG=chromium:664425 NOTRY=True TESTED=Ran: tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl --gyp-script=webrtc/build/gyp_webrtc.py //out/Release Review-Url: https://codereview.webrtc.org/2306163002 Cr-Commit-Position: refs/heads/master@{#15068}
49 lines
1.8 KiB
Python
49 lines
1.8 KiB
Python
# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
|
|
def _CommonChecks(input_api, output_api):
|
|
results = []
|
|
|
|
# Run Pylint over the files in the directory.
|
|
pylint_checks = input_api.canned_checks.GetPylint(input_api, output_api)
|
|
results.extend(input_api.RunTests(pylint_checks))
|
|
|
|
# Run the MB unittests.
|
|
results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
|
|
input_api, output_api, '.', [ r'^.+_unittest\.py$']))
|
|
|
|
# Validate the format of the mb_config.pyl file.
|
|
mb_config_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
|
|
'..', '..', 'webrtc', 'build',
|
|
'mb_config.pyl')
|
|
cmd = [input_api.python_executable, 'mb.py', 'validate', '--config-file',
|
|
mb_config_path]
|
|
kwargs = {'cwd': input_api.PresubmitLocalPath()}
|
|
results.extend(input_api.RunTests([
|
|
input_api.Command(name='mb_validate',
|
|
cmd=cmd, kwargs=kwargs,
|
|
message=output_api.PresubmitError)]))
|
|
|
|
results.extend(
|
|
input_api.canned_checks.CheckLongLines(
|
|
input_api,
|
|
output_api,
|
|
maxlen=80,
|
|
source_file_filter=lambda x: 'mb_config.pyl' in x.LocalPath()))
|
|
|
|
return results
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|