admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/pc
History
Philipp Hancke 13b327b05f srtp: demonstrate wraparound with loss decryption failure 
by encryption a packet with sequence number 65535 followed
by a packet with sequence number 1. The second packet is encrypted
with a SRTP ROC of 1 as described in
  https://datatracker.ietf.org/doc/html/rfc3711#section-3.3.1

The packets are (received and) decrypted in a different order,
the packet with sequence number 1 (and ROC=1) is decrypted first.
Since the ROC is maintained locally the decrypting session assumes
it to be 0.

Why is that a problem? The RFC recommends estimating the ROC with +-1 which, as demonstrated by the test, libSRTP does not.
But this is a rare problem that requires a random in a high range combined with packet loss/reordering which turns into no-a-problem if you choose carefully as done by packet_sequencer.cc which restricts the initial sequence number in the range 0..32767 which means you do not run into this issue in production.

See also Q6 in libsrtp's historical documentation at
  https://srtp.sourceforge.net/historical/faq.html

BUG=webrtc:353565743

Change-Id: I9bd72b198c946937aeb25c229005a0c682447f53
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358360
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#42798}
2024-08-19 05:17:18 +00:00
..
g3doc
Document how bitrate probing works from a RTP perspective
2023-06-09 14:14:12 +00:00
scenario_tests
Reland "Replace usage of link_capacity_kbps with DataRate link_capacity"
2024-05-16 10:39:10 +00:00
test
Apply include-cleaner to api/test/[^/]*
2024-08-13 15:28:34 +00:00
audio_rtp_receiver_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
audio_rtp_receiver.cc
Introduce the TransformerHost interface
2024-04-25 07:54:28 +00:00
audio_rtp_receiver.h
Introduce the TransformerHost interface
2024-04-25 07:54:28 +00:00
audio_track.cc
Move rtc::make_ref_counted to api/
2022-06-15 09:47:38 +00:00
audio_track.h
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
BUILD.gn
Apply include-cleaner to api/test/[^/]*
2024-08-13 15:28:34 +00:00
channel_interface.h
Remove all split channels related code
2023-06-29 09:32:04 +00:00
channel_unittest.cc
Deprecate cricket::VideoCodec and cricket::AudioCodec
2024-04-29 16:24:51 +00:00
channel.cc
Deprecate cricket::VideoCodec and cricket::AudioCodec
2024-04-29 16:24:51 +00:00
channel.h
Use webrtc::TaskQueueBase type instead of rtc::Thread
2023-10-30 14:43:46 +00:00
connection_context.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
connection_context.h
Deprecate rtc::RefCountInterface
2024-06-07 09:47:26 +00:00
data_channel_controller_unittest.cc
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
data_channel_controller.cc
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
data_channel_controller.h
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
data_channel_integrationtest.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
data_channel_unittest.cc
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
data_channel_utils.cc
…
data_channel_utils.h
Format ^(api|call|common_audio|examples|media|net|p2p|pc)/
2023-05-03 11:09:26 +00:00
DEPS
Remove the SctpDataChannel::config_ member variable.
2023-03-12 17:28:14 +00:00
dtls_srtp_transport_unittest.cc
Convert signals in rtp_transport_internal.h to CallbackList
2023-09-05 11:37:32 +00:00
dtls_srtp_transport.cc
Reduce logging verbosity of DTLS-SRTP RTCP transport
2023-08-22 13:48:09 +00:00
dtls_srtp_transport.h
Remove code for supporting SDES
2024-02-08 14:34:04 +00:00
dtls_transport_unittest.cc
Move rtc::make_ref_counted to api/
2022-06-15 09:47:38 +00:00
dtls_transport.cc
Reduce locking in DtlsTransport
2023-12-14 21:01:04 +00:00
dtls_transport.h
Reduce locking in DtlsTransport
2023-12-14 21:01:04 +00:00
dtmf_sender_unittest.cc
Remove sigslot usage from DtmfProviderInterface
2022-08-03 14:16:35 +00:00
dtmf_sender.cc
Replace Thread::Invoke with Thread::BlockingCall
2022-09-09 10:44:17 +00:00
dtmf_sender.h
Replace Thread::Invoke with Thread::BlockingCall
2022-09-09 10:44:17 +00:00
external_hmac.cc
…
external_hmac.h
Remove private SRTP include
2024-07-23 17:23:45 +00:00
ice_server_parsing_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
ice_server_parsing.cc
Reject stun urls with query parameters
2023-04-21 11:19:37 +00:00
ice_server_parsing.h
Reland "ice server parsing: return RTCError with more details"
2022-10-12 11:23:22 +00:00
ice_transport_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
ice_transport.cc
…
ice_transport.h
…
jitter_buffer_delay_unittest.cc
…
jitter_buffer_delay.cc
Use SequenceChecker(SequenceChecker::kDetached) in a few places.
2023-03-24 07:44:18 +00:00
jitter_buffer_delay.h
Use SequenceChecker(SequenceChecker::kDetached) in a few places.
2023-03-24 07:44:18 +00:00
jsep_ice_candidate.cc
…
jsep_session_description_unittest.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
jsep_session_description.cc
Move candidate type preference defaults to the Candidate class
2024-01-22 18:27:38 +00:00
jsep_transport_collection.cc
…
jsep_transport_collection.h
Use SequenceChecker(SequenceChecker::kDetached) in a few places.
2023-03-24 07:44:18 +00:00
jsep_transport_controller_unittest.cc
sctp: Pass webrtc::Environment to DcSctpTransport
2024-03-08 09:45:12 +00:00
jsep_transport_controller.cc
Reland "p2p: reduce visibility of ICE tiebreaker further"
2024-05-24 20:19:35 +00:00
jsep_transport_controller.h
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
jsep_transport_unittest.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
jsep_transport.cc
pc: Provide DtlsTransport to SctpTransport constr
2024-04-03 10:13:33 +00:00
jsep_transport.h
Remove code for supporting SDES
2024-02-08 14:34:04 +00:00
legacy_stats_collector_interface.h
Delete api/stats_types.h in favor of api/legacy_stats_types.h
2022-11-14 12:10:06 +00:00
legacy_stats_collector_unittest.cc
Move webrtc::AudioProcessing include to api/ folder
2024-04-20 07:02:50 +00:00
legacy_stats_collector.cc
Move webrtc::AudioProcessing include to api/ folder
2024-04-20 07:02:50 +00:00
legacy_stats_collector.h
Use is_* getters when checking the Candidate type
2024-01-19 15:37:32 +00:00
local_audio_source_unittest.cc
…
local_audio_source.cc
Move rtc::make_ref_counted to api/
2022-06-15 09:47:38 +00:00
local_audio_source.h
…
media_factory.h
Allow supplying a custom NetworkControllerInterfaceFactory per-Call in PeerConnectionDependencies
2024-07-29 07:17:14 +00:00
media_protocol_names.cc
Never pass a signed char to ctype macros like isdigit()
2022-05-30 13:05:03 +00:00
media_protocol_names.h
…
media_session_unittest.cc
Reland "Clean up SRTP helper functions"
2024-07-08 15:33:47 +00:00
media_session.cc
Treat negative SCTP message size limit as maximal (only bounded by buffer size)
2024-07-16 09:21:06 +00:00
media_session.h
Include-what-you-use pc/media_session
2024-05-08 15:07:53 +00:00
media_stream_observer.cc
…
media_stream_observer.h
…
media_stream_proxy.h
…
media_stream_track_proxy.h
…
media_stream_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
media_stream.cc
Move rtc::make_ref_counted to api/
2022-06-15 09:47:38 +00:00
media_stream.h
…
OWNERS
Enforce policy that SDP munging requires special approval
2023-01-30 20:09:07 +00:00
peer_connection_adaptation_integrationtest.cc
New PeerConnectionFactory::CreateVideoTrack with refcounted source
2023-03-22 09:10:27 +00:00
peer_connection_bundle_unittest.cc
Move webrtc::AudioDeviceModule include to api/ folder
2024-04-22 08:56:31 +00:00
peer_connection_crypto_unittest.cc
Move webrtc::AudioDeviceModule include to api/ folder
2024-04-22 08:56:31 +00:00
peer_connection_data_channel_unittest.cc
Migrate PeerConnection tests to EnableMedia api
2023-11-03 12:32:14 +00:00
peer_connection_encodings_integrationtest.cc
Fix VP9_Simulcast_SwitchToLegacySvc flakiness.
2024-07-03 13:42:49 +00:00
peer_connection_end_to_end_unittest.cc
Provide Environment to consturct AudioDecoder in tests
2024-08-16 14:34:37 +00:00
peer_connection_factory_proxy.h
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
peer_connection_factory_unittest.cc
Move webrtc::AudioDeviceModule include to api/ folder
2024-04-22 08:56:31 +00:00
peer_connection_factory.cc
Allow supplying a custom NetworkControllerInterfaceFactory per-Call in PeerConnectionDependencies
2024-07-29 07:17:14 +00:00
peer_connection_factory.h
Allow supplying a custom NetworkControllerInterfaceFactory per-Call in PeerConnectionDependencies
2024-07-29 07:17:14 +00:00
peer_connection_field_trial_tests.cc
Disable InjectDependencyDescriptor on Windows.
2024-03-19 10:25:18 +00:00
peer_connection_header_extension_unittest.cc
Deprecate RtcEventLogFactory constructor taking unused parameter
2023-12-07 21:46:56 +00:00
peer_connection_histogram_unittest.cc
Delete CallFactoryInterface as no longer needed
2023-12-05 15:44:43 +00:00
peer_connection_ice_unittest.cc
Move webrtc::AudioDeviceModule include to api/ folder
2024-04-22 08:56:31 +00:00
peer_connection_integrationtest.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
peer_connection_interface_unittest.cc
Move webrtc::AudioDeviceModule include to api/ folder
2024-04-22 08:56:31 +00:00
peer_connection_internal.h
Move webrtc::AudioDeviceModule include to api/ folder
2024-04-22 08:56:31 +00:00
peer_connection_jsep_unittest.cc
Move webrtc::AudioDeviceModule include to api/ folder
2024-04-22 08:56:31 +00:00
peer_connection_media_unittest.cc
Deprecate rtc::RefCountInterface
2024-06-07 09:47:26 +00:00
peer_connection_message_handler.cc
Rename api/stats_types.h to api/legacy_stats_types.h.
2022-11-11 10:29:25 +00:00
peer_connection_message_handler.h
Rename api/stats_types.h to api/legacy_stats_types.h.
2022-11-11 10:29:25 +00:00
peer_connection_proxy.h
Expose a PeerConnection's NetworkControllerInterface instance
2024-06-18 08:04:03 +00:00
peer_connection_rampup_tests.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
peer_connection_rtp_unittest.cc
Move webrtc::AudioDeviceModule include to api/ folder
2024-04-22 08:56:31 +00:00
peer_connection_signaling_unittest.cc
Move webrtc::AudioDeviceModule include to api/ folder
2024-04-22 08:56:31 +00:00
peer_connection_simulcast_unittest.cc
Remove more sstream deps
2024-07-09 10:30:26 +00:00
peer_connection_svc_integrationtest.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
peer_connection_wrapper.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
peer_connection_wrapper.h
Enable the use of CreateDataChannel with a DataChannelInit config.
2023-02-10 12:24:47 +00:00
peer_connection.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
peer_connection.h
Expose a PeerConnection's NetworkControllerInterface instance
2024-06-18 08:04:03 +00:00
proxy_unittest.cc
Deprecate rtc::RefCountInterface
2024-06-07 09:47:26 +00:00
proxy.h
Deprecate rtc::RefCountInterface
2024-06-07 09:47:26 +00:00
remote_audio_source.cc
Split audio and video channels into Send and Receive APIs.
2022-12-14 11:00:17 +00:00
remote_audio_source.h
Split audio and video channels into Send and Receive APIs.
2022-12-14 11:00:17 +00:00
rtc_stats_collector_unittest.cc
Computing and propagating the audio stats totalprocessingdelay.
2024-06-18 08:05:28 +00:00
rtc_stats_collector.cc
Computing and propagating the audio stats totalprocessingdelay.
2024-06-18 08:05:28 +00:00
rtc_stats_collector.h
Deprecate rtc::RefCountInterface
2024-06-07 09:47:26 +00:00
rtc_stats_integrationtest.cc
Computing and propagating the audio stats totalprocessingdelay.
2024-06-18 08:05:28 +00:00
rtc_stats_traversal_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
rtc_stats_traversal.cc
[Stats] Migrate from the RTCStatsMember type alias to absl::optional.
2024-01-25 21:56:08 +00:00
rtc_stats_traversal.h
…
rtcp_mux_filter_unittest.cc
…
rtcp_mux_filter.cc
…
rtcp_mux_filter.h
…
rtp_media_utils_unittest.cc
…
rtp_media_utils.cc
…
rtp_media_utils.h
Remove <ostream> dependencies
2024-07-03 12:27:55 +00:00
rtp_parameters_conversion_unittest.cc
Deprecate cricket::VideoCodec and cricket::AudioCodec
2024-04-29 16:24:51 +00:00
rtp_parameters_conversion.cc
Reland "Merge the codec types"
2023-06-15 15:53:29 +00:00
rtp_parameters_conversion.h
Reland "Merge the codec types"
2023-06-15 15:53:29 +00:00
rtp_receiver_proxy.h
Reland "Run IWYU on some files I intend to work on"
2024-06-05 08:59:49 +00:00
rtp_receiver.cc
Reland "Run IWYU on some files I intend to work on"
2024-06-05 08:59:49 +00:00
rtp_receiver.h
Reland "Run IWYU on some files I intend to work on"
2024-06-05 08:59:49 +00:00
rtp_sender_proxy.h
Introduce the TransformerHost interface
2024-04-25 07:54:28 +00:00
rtp_sender_receiver_unittest.cc
Reland "Run IWYU on some files I intend to work on"
2024-06-05 08:59:49 +00:00
rtp_sender.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
rtp_sender.h
Introduce the TransformerHost interface
2024-04-25 07:54:28 +00:00
rtp_transceiver_unittest.cc
Reland "Enable DD and VLA header extensions by default for Simulcast/SVC"
2024-01-26 06:08:28 +00:00
rtp_transceiver.cc
Reland "Run IWYU on some files I intend to work on"
2024-06-05 08:59:49 +00:00
rtp_transceiver.h
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
rtp_transmission_manager.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
rtp_transmission_manager.h
Delete some unused sigslot includes
2023-08-28 12:36:39 +00:00
rtp_transport_internal.h
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
rtp_transport_unittest.cc
Propagate ECN to RtpPacketReceived
2024-03-15 08:58:28 +00:00
rtp_transport.cc
Propagate ECN to RtpPacketReceived
2024-03-15 08:58:28 +00:00
rtp_transport.h
Propagate ECN to RtpPacketReceived
2024-03-15 08:58:28 +00:00
sctp_data_channel.cc
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
sctp_data_channel.h
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
sctp_transport_unittest.cc
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
sctp_transport.cc
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
sctp_transport.h
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
sctp_utils_unittest.cc
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
sctp_utils.cc
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
sctp_utils.h
Change DataChannelInit::priority to integer and forward to SCTP transport
2024-07-30 15:07:25 +00:00
sdp_offer_answer_unittest.cc
deflake rtcp-rsize test in TSAN
2024-05-27 12:51:11 +00:00
sdp_offer_answer.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
sdp_offer_answer.h
Reland "Run IWYU on some files I intend to work on"
2024-06-05 08:59:49 +00:00
sdp_state_provider.h
…
sdp_utils.cc
…
sdp_utils.h
…
session_description_unittest.cc
…
session_description.cc
Format ^(api|call|common_audio|examples|media|net|p2p|pc)/
2023-05-03 11:09:26 +00:00
session_description.h
Remove code for supporting SDES
2024-02-08 14:34:04 +00:00
simulcast_description.cc
…
simulcast_description.h
…
simulcast_sdp_serializer_unittest.cc
Rename simulcast SDP serializer
2023-09-18 10:09:02 +00:00
simulcast_sdp_serializer.cc
Rename simulcast SDP serializer
2023-09-18 10:09:02 +00:00
simulcast_sdp_serializer.h
Rename simulcast SDP serializer
2023-09-18 10:09:02 +00:00
slow_peer_connection_integration_test.cc
Use rtc::ReceivedPacket in Stun and TurnServer
2023-11-23 10:40:56 +00:00
srtp_session_unittest.cc
srtp: demonstrate wraparound with loss decryption failure
2024-08-19 05:17:18 +00:00
srtp_session.cc
Remove SSRCs from libSRTP when removing them from the rtp_demuxer
2023-11-08 10:24:10 +00:00
srtp_session.h
Remove SSRCs from libSRTP when removing them from the rtp_demuxer
2023-11-08 10:24:10 +00:00
srtp_transport_unittest.cc
Reland "Clean up SRTP helper functions"
2024-07-08 15:33:47 +00:00
srtp_transport.cc
Propagate ECN to RtpPacketReceived
2024-03-15 08:58:28 +00:00
srtp_transport.h
Propagate rtc::ReceivedPacket further in RtpTransport
2024-02-27 17:46:18 +00:00
stream_collection.h
…
track_media_info_map_unittest.cc
Delete deprecated 'track' and 'stream' metrics from WebRTC.
2023-05-24 12:26:56 +00:00
track_media_info_map.cc
Delete deprecated 'track' and 'stream' metrics from WebRTC.
2023-05-24 12:26:56 +00:00
track_media_info_map.h
Delete deprecated 'track' and 'stream' metrics from WebRTC.
2023-05-24 12:26:56 +00:00
transceiver_list.cc
…
transceiver_list.h
…
transport_stats.cc
…
transport_stats.h
Add histogram for DTLS peer signature algorithm
2023-10-06 12:25:37 +00:00
usage_pattern.cc
…
usage_pattern.h
…
used_ids_unittest.cc
Dynamically assign ids to header extensions not enabled by default
2024-02-08 12:52:58 +00:00
used_ids.h
Dynamically assign ids to header extensions not enabled by default
2024-02-08 12:52:58 +00:00
video_rtp_receiver_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
video_rtp_receiver.cc
Introduce the TransformerHost interface
2024-04-25 07:54:28 +00:00
video_rtp_receiver.h
Introduce the TransformerHost interface
2024-04-25 07:54:28 +00:00
video_rtp_track_source_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
video_rtp_track_source.cc
Use SequenceChecker(SequenceChecker::kDetached) in a few places.
2023-03-24 07:44:18 +00:00
video_rtp_track_source.h
Use SequenceChecker(SequenceChecker::kDetached) in a few places.
2023-03-24 07:44:18 +00:00
video_track_source_proxy.cc
…
video_track_source_proxy.h
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
video_track_source.cc
Use SequenceChecker(SequenceChecker::kDetached) in a few places.
2023-03-24 07:44:18 +00:00
video_track_source.h
Use SequenceChecker(SequenceChecker::kDetached) in a few places.
2023-03-24 07:44:18 +00:00
video_track_unittest.cc
Move rtc::make_ref_counted to api/
2022-06-15 09:47:38 +00:00
video_track.cc
Replace Thread::Invoke with Thread::BlockingCall
2022-09-09 10:44:17 +00:00
video_track.h
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
webrtc_sdp_unittest.cc
Break out parsing of FMTP lines so that others can use it
2024-05-16 10:22:23 +00:00
webrtc_sdp.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
webrtc_sdp.h
Break out parsing of FMTP lines so that others can use it
2024-05-16 10:22:23 +00:00
webrtc_session_description_factory.cc
Remove code for supporting SDES
2024-02-08 14:34:04 +00:00
webrtc_session_description_factory.h
Remove code for supporting SDES
2024-02-08 14:34:04 +00:00