2419dc9cfc
This reverts commit 53e157d25ce78ba6cd8625b0b655b46f8e1b0a91. Reason for revert: Breaks Chromium iOS FYI bots. https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20ios-device/5088 Original change's description: > Force Chromium deps on the WebRTC component. > > This CL adds a visibility check to the rtc_* GN templates in order > to force Chromium to depend only on publicly visible targets from > //third_party/webrtc_overrides and not from //third_party/webrtc. > > This is required in order to ensure that the Chromium's component > builds continues to work correctly without introducing direct > dependency paths on WebRTC that would statically link it in multiple > shared libraries. > > Bug: webrtc:9419 > Change-Id: Ib89f4fc571512f99678ee4f61696b316374346d9 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154344 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29806} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR: kwiberg@webrtc.org Bug: webrtc:9419 Change-Id: Id4d906910d569a3e5db3afef8c03672fba6dad81 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159921 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29813}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.