9e5aeb9d92
Since the lifetime of an SctpDataChannel is not strictly controlled by its controller, the controller might go away before the channel does. This CL guards against this. Bug: webrtc:13931 Change-Id: I07046fe896d1a66bf89287429beb0587382a13a9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261940 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36852}
76 lines
2.3 KiB
C++
76 lines
2.3 KiB
C++
/*
|
|
* Copyright 2022 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "pc/data_channel_controller.h"
|
|
|
|
#include <memory>
|
|
|
|
#include "pc/peer_connection_internal.h"
|
|
#include "pc/sctp_data_channel.h"
|
|
#include "pc/test/mock_peer_connection_internal.h"
|
|
#include "test/gmock.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
|
|
namespace {
|
|
|
|
using ::testing::NiceMock;
|
|
using ::testing::Return;
|
|
|
|
class DataChannelControllerTest : public ::testing::Test {
|
|
protected:
|
|
DataChannelControllerTest() {
|
|
pc_ = rtc::make_ref_counted<NiceMock<MockPeerConnectionInternal>>();
|
|
ON_CALL(*pc_, signaling_thread)
|
|
.WillByDefault(Return(rtc::Thread::Current()));
|
|
}
|
|
|
|
rtc::scoped_refptr<NiceMock<MockPeerConnectionInternal>> pc_;
|
|
};
|
|
|
|
TEST_F(DataChannelControllerTest, CreateAndDestroy) {
|
|
DataChannelController dcc(pc_.get());
|
|
}
|
|
|
|
TEST_F(DataChannelControllerTest, CreateDataChannelEarlyRelease) {
|
|
DataChannelController dcc(pc_.get());
|
|
auto channel = dcc.InternalCreateDataChannelWithProxy(
|
|
"label",
|
|
std::make_unique<InternalDataChannelInit>(DataChannelInit()).get());
|
|
channel = nullptr; // dcc holds a reference to channel, so not destroyed yet
|
|
}
|
|
|
|
TEST_F(DataChannelControllerTest, CreateDataChannelLateRelease) {
|
|
auto dcc = std::make_unique<DataChannelController>(pc_.get());
|
|
auto channel = dcc->InternalCreateDataChannelWithProxy(
|
|
"label",
|
|
std::make_unique<InternalDataChannelInit>(DataChannelInit()).get());
|
|
dcc.reset();
|
|
channel = nullptr;
|
|
}
|
|
|
|
TEST_F(DataChannelControllerTest, CloseAfterControllerDestroyed) {
|
|
auto dcc = std::make_unique<DataChannelController>(pc_.get());
|
|
auto channel = dcc->InternalCreateDataChannelWithProxy(
|
|
"label",
|
|
std::make_unique<InternalDataChannelInit>(DataChannelInit()).get());
|
|
// Connect to provider
|
|
auto inner_channel =
|
|
DowncastProxiedDataChannelInterfaceToSctpDataChannelForTesting(
|
|
channel.get());
|
|
dcc->ConnectDataChannel(inner_channel);
|
|
dcc.reset();
|
|
channel->Close();
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace webrtc
|