9d8eaac4ee
And delete corresponding dependencies on :webrtc_common. After this change, common_types.h is included directly only from code in the following directories: api/ api/video/ api/video_codecs/ common_video/libyuv/include/ media/base/ modules/remote_bitrate_estimator/ modules/rtp_rtcp/source/ modules/video_coding/codecs/vp9/ There remains plenty of indirect dependencies on the types declared in common_types.h, but the fewer direct dependencies should make it easier to find the proper place for each type. Bug: webrtc:5876 Change-Id: I93e8f214025ecb613c19fdec2015bd3f96c59aae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130501 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27376}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.