9b7232a68c
Several tests leave pending tasks behind after executing, which may affect the state of subsequent tests. This CL isolates each test in the sense that a dedicated Thread instance is created per test and then pending tasks are flushed and the Thread instance deleted. Down the line we may want to improve on this and flag those tests that leave pending tasks/timers etc. Change-Id: Ibaf3719a9974c57ac2169edca0e2a06a9ea6c78f Bug: webrtc:11574 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175132 Commit-Queue: Tommi <tommi@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31268}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.