31718d7ce2
This reverts commit 83102d39077f82f2d4539c160c659dcf789a5fdb. Reason for revert: reland with fix Original change's description: > Revert "Add option to disable quality scaling for AV1." > > This reverts commit 446dbc66fde7e9d5e684d3f71e357c2076a91740. > > Reason for revert: downstream break > > Original change's description: > > Add option to disable quality scaling for AV1. > > > > The main goal of this change is to disable the quality scaler when multiple spatial layers are used. > > > > Bug: b/295129711 > > Change-Id: I25e0b7440a8c2adee3e97720a1e0ee5e0a914334 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/319181 > > Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#40709} > > Bug: b/295129711 > Change-Id: Iaeb13951d1b839bc0426120436035843bb3ee98f > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320081 > Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Owners-Override: Philip Eliasson <philipel@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#40742} Bug: b/295129711 Change-Id: Iab4846c2cd6074f50a3ebe9551432d449243b5d7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320120 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40743}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.- Avoid structs in api, prefer classes.
The preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.
Avoid defining api with structs as it makes harder for the api to evolve. Your struct may gain invariant, or change how it represents data. Evolving struct from the api is particular challenging as it is designed to be used in other code bases and thus needs to be updated independetly from its usage. Class with accessors and setters makes such migration safer. See Google C++ style guide for more.
If you need to evolve existent struct in api, prefer first to convert it into a class.