14665ff7d4
Clang version changed 223108:230914
Details: e144d30..6fdb142/tools/clang/scripts/update.sh
Removes the OVERRIDE macro defined in:
* webrtc/base/common.h
* webrtc/typedefs.h
The majority of the source changes were done by running this in src/:
perl -0pi -e "s/virtual\s([^({;]*(\([^({;]*\)[^({;]*))(OVERRIDE|override)/\1override/sg" `find {talk,webrtc} -name "*.h" -o -name "*.cc*" -o -name "*.mm*"`
which converted all:
virtual Foo() OVERRIDE
functions to:
Foo() override
Then I manually edited:
* talk/media/webrtc/fakewebrtccommon.h
* webrtc/test/fake_common.h
Remaining uses of OVERRIDE was fixed by search+replace.
Manual edits were done to fix virtual destructors that were
overriding inherited ones.
Finally a build error related to the pure virtual definitions of
Read, Write and Rewind in common_types.h required a bit of
refactoring in:
* webrtc/common_types.cc
* webrtc/common_types.h
* webrtc/system_wrappers/interface/file_wrapper.h
* webrtc/system_wrappers/source/file_impl.cc
This roll should make it possible for us to finally re-enable deadlock
detection for TSan on the buildbots.
BUG=4106
R=pbos@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41069004
Cr-Commit-Position: refs/heads/master@{#8596}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d
53 lines
1.8 KiB
C++
53 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_TEST_TEST_SUPPORT_TRACE_TO_STDERR_H_
|
|
#define WEBRTC_TEST_TEST_SUPPORT_TRACE_TO_STDERR_H_
|
|
|
|
#include "webrtc/system_wrappers/interface/trace.h"
|
|
|
|
namespace webrtc {
|
|
namespace test {
|
|
|
|
// Upon constructing an instance of this class, all traces will be redirected
|
|
// to stderr. At destruction, redirection is halted.
|
|
class TraceToStderr : public TraceCallback {
|
|
public:
|
|
TraceToStderr();
|
|
// Set |override_time| to true to control the time printed with each trace
|
|
// through SetTimeSeconds(). Otherwise, the trace's usual wallclock time is
|
|
// used.
|
|
//
|
|
// This is useful for offline test tools, where the file time is much more
|
|
// informative than the real time.
|
|
explicit TraceToStderr(bool override_time);
|
|
~TraceToStderr() override;
|
|
|
|
// Every subsequent trace printout will use |time|. Has no effect if
|
|
// |override_time| in the constructor was set to false.
|
|
//
|
|
// No attempt is made to ensure thread-safety between the trace writing and
|
|
// time updating. In tests, since traces will normally be triggered by the
|
|
// main thread doing the time updating, this should be of no concern.
|
|
virtual void SetTimeSeconds(float time);
|
|
|
|
// Implements TraceCallback.
|
|
void Print(TraceLevel level, const char* msg_array, int length) override;
|
|
|
|
private:
|
|
bool override_time_;
|
|
float time_seconds_;
|
|
};
|
|
|
|
} // namespace test
|
|
} // namespace webrtc
|
|
|
|
#endif // WEBRTC_TEST_TEST_SUPPORT_TRACE_TO_STDERR_H_
|