14665ff7d4
Clang version changed 223108:230914
Details: e144d30..6fdb142/tools/clang/scripts/update.sh
Removes the OVERRIDE macro defined in:
* webrtc/base/common.h
* webrtc/typedefs.h
The majority of the source changes were done by running this in src/:
perl -0pi -e "s/virtual\s([^({;]*(\([^({;]*\)[^({;]*))(OVERRIDE|override)/\1override/sg" `find {talk,webrtc} -name "*.h" -o -name "*.cc*" -o -name "*.mm*"`
which converted all:
virtual Foo() OVERRIDE
functions to:
Foo() override
Then I manually edited:
* talk/media/webrtc/fakewebrtccommon.h
* webrtc/test/fake_common.h
Remaining uses of OVERRIDE was fixed by search+replace.
Manual edits were done to fix virtual destructors that were
overriding inherited ones.
Finally a build error related to the pure virtual definitions of
Read, Write and Rewind in common_types.h required a bit of
refactoring in:
* webrtc/common_types.cc
* webrtc/common_types.h
* webrtc/system_wrappers/interface/file_wrapper.h
* webrtc/system_wrappers/source/file_impl.cc
This roll should make it possible for us to finally re-enable deadlock
detection for TSan on the buildbots.
BUG=4106
R=pbos@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41069004
Cr-Commit-Position: refs/heads/master@{#8596}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d
71 lines
2.2 KiB
C++
71 lines
2.2 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_TEST_TESTSUPPORT_FRAME_WRITER_H_
|
|
#define WEBRTC_TEST_TESTSUPPORT_FRAME_WRITER_H_
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <string>
|
|
|
|
#include "webrtc/typedefs.h"
|
|
|
|
namespace webrtc {
|
|
namespace test {
|
|
|
|
// Handles writing of video files.
|
|
class FrameWriter {
|
|
public:
|
|
virtual ~FrameWriter() {}
|
|
|
|
// Initializes the file handler, i.e. opens the input and output files etc.
|
|
// This must be called before reading or writing frames has started.
|
|
// Returns false if an error has occurred, in addition to printing to stderr.
|
|
virtual bool Init() = 0;
|
|
|
|
// Writes a frame of the configured frame length to the output file.
|
|
// Returns true if the write was successful, false otherwise.
|
|
virtual bool WriteFrame(uint8_t* frame_buffer) = 0;
|
|
|
|
// Closes the output file if open. Essentially makes this class impossible
|
|
// to use anymore. Will also be invoked by the destructor.
|
|
virtual void Close() = 0;
|
|
|
|
// Frame length in bytes of a single frame image.
|
|
virtual size_t FrameLength() = 0;
|
|
};
|
|
|
|
class FrameWriterImpl : public FrameWriter {
|
|
public:
|
|
// Creates a file handler. The input file is assumed to exist and be readable
|
|
// and the output file must be writable.
|
|
// Parameters:
|
|
// output_filename The file to write. Will be overwritten if already
|
|
// existing.
|
|
// frame_length_in_bytes The size of each frame.
|
|
// For YUV: 3*width*height/2
|
|
FrameWriterImpl(std::string output_filename, size_t frame_length_in_bytes);
|
|
~FrameWriterImpl() override;
|
|
bool Init() override;
|
|
bool WriteFrame(uint8_t* frame_buffer) override;
|
|
void Close() override;
|
|
size_t FrameLength() override;
|
|
|
|
private:
|
|
std::string output_filename_;
|
|
size_t frame_length_in_bytes_;
|
|
FILE* output_file_;
|
|
};
|
|
|
|
} // namespace test
|
|
} // namespace webrtc
|
|
|
|
#endif // WEBRTC_TEST_TESTSUPPORT_FRAME_WRITER_H_
|