8dbbd648e7
This reverts commit 8d4cdd11d8d4ce3e6ddbe9c729c7cfbd8f495880. Reason for revert: Upstream project needs have changed Original change's description: > Ignore frames that are comming to DVQA after Stop is called > > Bug: webrtc:12247 > Change-Id: Ie3e773bdff66c900956019ac3131bbdb9ee874cd > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196084 > Reviewed-by: Sebastian Jansson <srte@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Andrey Logvin <landrey@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32738} TBR=mbonadei@webrtc.org,srte@webrtc.org,landrey@webrtc.org Change-Id: Ie7483435eae9b0344f875673ca9651ff4d591bd3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:12247 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196280 Reviewed-by: Andrey Logvin <landrey@webrtc.org> Commit-Queue: Andrey Logvin <landrey@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32746}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.