c69453d93b
With these changes, we now often have 0 invokes and at most 1 when calling SetLocalContent on a channel. Before we had at least 1 and typically 2. Summary of changes. * Updating RtpExtension::DeduplicateHeaderExtensions to return a sorted vector (+test) for easy detection of changes. * Before updating the transport on the network thread, detect if actual changes to the demuxer criteria or changes to the rtp header extensions have been made. * Consolidate both transport updates to a single call instead of two. * Added DCHECK guards to catch regressions in number of invokes. A possible upcoming improvement is to update the transport asynchronously. Bug: webrtc:13536 Change-Id: I71ef7b181635a796ffa1e3a02a0f661d28a4870c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244700 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35638}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.