ivica
8d15bd6dab
Reland of Collecting encode_time_ms for each frame (patchset #1 id:1 of https://codereview.webrtc.org/1383283005/ )
Reason for revert:
The reverted commit didn't affect the tests, but the one before: https://codereview.webrtc.org/1385563005/
I've run the test that was failing (EndToEndTest.AssignsTransportSequenceNumbers) locally multiple times, and it works fine (finishes successfully in 150-170ms).
Original issue's description:
> Revert of Collecting encode_time_ms for each frame (patchset #13 id:220001 of https://codereview.webrtc.org/1374233002/ )
>
> Reason for revert:
> Breaks EndToEndTest.AssignsTransportSequenceNumbers in video_engine_tests
> on several bots:
> http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5507
> http://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/4815
> http://build.chromium.org/p/client.webrtc/builders/Win%20SyzyASan/builds/3272
> http://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4414
>
> It seems very unfortunate that it breaks on _exactly_ the bot configs that aren't covered by the CQ trybots.
>
> Original issue's description:
> > Collecting encode_time_ms for each frame.
> >
> > Also, in Sample struct, replacing double with the original type.
> > It makes more sense to save the original data as truthful as possible, and then
> > convert it to double later if necessary (in the plot script).
> >
> > Committed: https://crrev.com/092b13384e57b33e2003d9736dfa1f491e76f938
> > Cr-Commit-Position: refs/heads/master@{#10184}
>
> TBR=sprang@webrtc.org,pbos@webrtc.org,mflodman@webrtc.org,asapersson@webrtc.org,ivica@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/810447972425e890bc7911af27f894b86e9b7e6f
> Cr-Commit-Position: refs/heads/master@{#10185}
TBR=sprang@webrtc.org,pbos@webrtc.org,mflodman@webrtc.org,asapersson@webrtc.org,kjellander@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1390163002
Cr-Commit-Position: refs/heads/master@{#10195}
2015-10-07 09:43:25 +00:00
..
2015-09-25 11:58:39 +00:00
2015-09-17 07:24:51 +00:00
2014-12-01 15:23:21 +00:00
2015-10-06 19:27:12 +00:00
2015-10-07 09:43:25 +00:00
2015-10-06 09:04:15 +00:00
2015-09-25 11:58:39 +00:00
2015-10-05 12:59:50 +00:00
2015-09-29 09:26:50 +00:00
2015-10-06 11:08:22 +00:00
2015-10-06 11:08:22 +00:00
2015-09-17 07:24:51 +00:00
2015-09-24 13:07:17 +00:00
2015-09-22 14:29:00 +00:00
2015-10-06 12:05:03 +00:00
2015-10-05 09:36:20 +00:00
2015-10-07 09:43:25 +00:00
2015-10-07 09:43:25 +00:00
2015-10-07 09:43:25 +00:00
2015-05-30 00:21:56 +00:00
2015-09-17 07:24:51 +00:00
2015-06-05 09:08:12 +00:00
2015-09-17 07:24:51 +00:00
2015-09-24 13:07:17 +00:00
2015-10-07 09:43:25 +00:00
2015-09-28 16:59:36 +00:00
2015-10-02 09:37:18 +00:00
2015-10-02 09:37:18 +00:00
2015-10-02 09:37:18 +00:00
2015-10-07 09:43:25 +00:00
2015-09-25 11:58:39 +00:00
2015-09-25 11:58:39 +00:00