20ee02c49f
SdpVideoFormat is used to configure video encoder and decoders. This CL adds support for comparing two SdpVideoFormat objects to determine if they specify the same video codec. This functionality previously only existed in media/base/codec.h which made the code sensitive to circular dependencies. Once downstream projects stop using cricket::IsSameCodec, this code can be removed. Bug: chromium:1187565 Change-Id: I242069aa6af07917637384c80ee4820887defc7d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213427 Commit-Queue: Johannes Kron <kron@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33794}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.