admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/webrtc/modules/video_coding
History
Guido Urdaneta 88f94fa36a Revert "Update video_coding/codecs to new VideoFrameBuffer interface" 
This reverts commit 20ebf4ede803cd4f628ef9378700f60b72f2eab0.

Reason for revert:

Suspect of breaking FYI bots.
See https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/builds/9036 and others.

Sample logs:
Backtrace:
[5024:1036:0607/173649.857:FATAL:webrtc_video_frame_adapter.cc(98)] Check failed: false. 
Backtrace:
	base::debug::StackTrace::StackTrace [0x02D04A37+55]
	base::debug::StackTrace::StackTrace [0x02CCBB8A+10]
	content::WebRtcVideoFrameAdapter::NativeToI420Buffer [0x0508AD71+305]
	webrtc::VideoFrameBuffer::ToI420 [0x0230BF67+39]
	webrtc::H264EncoderImpl::Encode [0x057E8D0B+267]
	webrtc::VCMGenericEncoder::Encode [0x057E0E34+333]
	webrtc::vcm::VideoSender::AddVideoFrame [0x057DED9B+796]
	webrtc::ViEEncoder::EncodeVideoFrame [0x057C00F6+884]
	webrtc::ViEEncoder::EncodeTask::Run [0x057C12D7+215]
	rtc::TaskQueue::PostTask [0x03EE5CFB+194]
	base::internal::Invoker<base::internal::BindState<enum extensions::`anonymous namespace'::VerificationResult (__cdecl*)(std::unique_ptr<extensions::NetworkingCastPrivateDelegate::Credentials,std::default_delete<extensions::NetworkingCastPrivateDelegate::C [0x02DDCAA5+31]
	base::internal::Invoker<base::internal::BindState<enum extensions::`anonymous namespace'::VerificationResult (__cdecl*)(std::unique_ptr<extensions::NetworkingCastPrivateDelegate::Credentials,std::default_delete<extensions::NetworkingCastPrivateDelegate::C [0x02DDEE86+22]
	base::debug::TaskAnnotator::RunTask [0x02D08289+409]
	base::MessageLoop::RunTask [0x02C8CEC1+1233]
	base::MessageLoop::DoWork [0x02C8C1AD+765]
	base::MessagePumpDefault::Run [0x02D0A20B+219]
	base::MessageLoop::Run [0x02C8C9DB+107]
	base::RunLoop::Run [0x02C89583+147]
	base::Thread::Run [0x02CBEFCD+173]
	base::Thread::ThreadMain [0x02CBFADE+622]
	base::PlatformThread::Sleep [0x02C9E1A2+290]
	BaseThreadInitThunk [0x75C3338A+18]
	RtlInitializeExceptionChain [0x773A9902+99]
	RtlInitializeExceptionChain [0x773A98D5+54]

Original change's description:
> Update video_coding/codecs to new VideoFrameBuffer interface
> 
> This is a follow-up cleanup for CL
> https://codereview.webrtc.org/2847383002/.
> 
> Bug: webrtc:7632
> Change-Id: I47861d779968f2fee94db9c017102a8e87e67fb7
> Reviewed-on: https://chromium-review.googlesource.com/524163
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> Reviewed-by: Niels Moller <nisse@webrtc.org>
> Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#18477}

TBR=magjed@webrtc.org,nisse@webrtc.org,brandtr@webrtc.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7632

Change-Id: I3b73fc7d16ff19ceba196e964dcb36a36510912c
Reviewed-on: https://chromium-review.googlesource.com/527793
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18489}
2017-06-08 08:33:52 +00:00
..
codecs
Revert "Update video_coding/codecs to new VideoFrameBuffer interface"
2017-06-08 08:33:52 +00:00
include
Move webrtc/video_frame to common_video/include.
2017-05-15 09:42:11 +00:00
test
Delete unused test code in modules/video_coding/test/
2017-03-17 15:11:11 +00:00
utility
MediaCodecVideoEncoder: Add QP stats to Encoded callback for VP9 and turn on quality scaling.
2017-06-07 11:09:45 +00:00
BUILD.gn
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ )
2017-05-30 08:48:47 +00:00
codec_database.cc
vp9: Enable vp9 denoiser by default in standalone webrtc.
2017-06-05 20:43:49 +00:00
codec_database.h
Revert of Deliver video frames on Android, on the decode thread. (patchset #7 id:120001 of https://codereview.webrtc.org/2764573002/ )
2017-04-04 14:16:21 +00:00
codec_timer.cc
Reland of VCMCodecTimer: Change filter from max to 95th percentile (patchset #1 id:1 of https://codereview.webrtc.org/1808693002/ )
2016-03-22 12:12:12 +00:00
codec_timer.h
Rename base/analytics/ to base/numerics/
2017-01-13 17:14:33 +00:00
decoding_state_unittest.cc
Reland of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.
2017-01-10 12:21:35 +00:00
decoding_state.cc
Added sanity check to VCMDecodingState::UsingFlexibleMode to prevent OOB error.
2016-11-29 15:01:29 +00:00
decoding_state.h
Revert "Revert of Use sps and pps to determine decodability of H.264 frames. (patchset #4 id:60001 of https://codereview.webrtc.org/2341713002/ )"
2016-10-06 12:04:59 +00:00
DEPS
Add support for creating HW codecs in the VideoProcessor tests.
2017-02-20 12:35:52 +00:00
encoded_frame.cc
Reland of Add content type information to encoded images and corresponding rtp extension header (patchset #1 id:1 of https://codereview.webrtc.org/2809653004/ )
2017-04-11 17:34:31 +00:00
encoded_frame.h
Move webrtc/video_frame to common_video/include.
2017-05-15 09:42:11 +00:00
fec_rate_table.h
Rename fec_tables_xor.h -> fec_rate_table.h
2017-01-12 14:16:24 +00:00
frame_buffer2_unittest.cc
Configured VCMTiming with sender defining delay times.
2017-05-10 16:21:33 +00:00
frame_buffer2.cc
More gracefully handle timing errors, such as unexpected changes in the rtp timestamp.
2017-05-23 16:52:18 +00:00
frame_buffer2.h
More gracefully handle timing errors, such as unexpected changes in the rtp timestamp.
2017-05-23 16:52:18 +00:00
frame_buffer.cc
Reland of Add content type information to encoded images and corresponding rtp extension header (patchset #1 id:1 of https://codereview.webrtc.org/2809653004/ )
2017-04-11 17:34:31 +00:00
frame_buffer.h
Revert "Revert of Use sps and pps to determine decodability of H.264 frames. (patchset #4 id:60001 of https://codereview.webrtc.org/2341713002/ )"
2016-10-06 12:04:59 +00:00
frame_object.cc
Cast sequence number in RtpFrameObject.
2017-05-23 15:19:11 +00:00
frame_object.h
Don't update the jitter estimate with frames containing retransmitted packets.
2017-01-25 16:56:23 +00:00
generic_decoder.cc
Reland of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/2853383005/ )
2017-05-10 12:25:59 +00:00
generic_decoder.h
Reland of Add content type information to encoded images and corresponding rtp extension header (patchset #1 id:1 of https://codereview.webrtc.org/2809653004/ )
2017-04-11 17:34:31 +00:00
generic_encoder.cc
Propagate input capture time in ViEEncoder::OnFrame.
2017-05-31 13:33:21 +00:00
generic_encoder.h
Remove ALL usage of CriticalSectionWrapper.
2017-03-31 09:03:55 +00:00
h264_sprop_parameter_sets_unittest.cc
Reland of place basictypes.h with stdint.h for int_t types. (patchset #1 id:1 of https://codereview.webrtc.org/2603203003/ )
2017-01-02 16:42:32 +00:00
h264_sprop_parameter_sets.cc
Unit test out of band H264 SPS,PPS within RtpStreamReceiver.
2017-01-24 12:38:27 +00:00
h264_sprop_parameter_sets.h
Delete unneeded includes of base/common.h.
2017-01-25 09:47:24 +00:00
h264_sps_pps_tracker_unittest.cc
Check H264 NALUs for frametype and insert SPS/PPS packets into the PacketBuffer.
2017-05-19 13:38:50 +00:00
h264_sps_pps_tracker.cc
Check H264 NALUs for frametype and insert SPS/PPS packets into the PacketBuffer.
2017-05-19 13:38:50 +00:00
h264_sps_pps_tracker.h
Reland of Save width/height of SPS nalus and restore them on the first packet of an IDR. (patchset #1 id:1 of https://codereview.webrtc.org/2754543005/ )
2017-03-17 13:12:33 +00:00
histogram_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
histogram.cc
RTC_[D]CHECK_op: Remove "u" suffix on integer constants
2016-11-28 23:21:51 +00:00
histogram.h
Revert "Revert of Implement the NackModule as part of the new jitter buffer. (patchset #19 id:360001 of https://codereview.webrtc.org/1715673002/ )"
2016-03-08 11:36:22 +00:00
inter_frame_delay.cc
Lint fix for webrtc/modules/video_coding PART 2!
2015-12-21 12:12:45 +00:00
inter_frame_delay.h
Lint fix for webrtc/modules/video_coding PART 2!
2015-12-21 12:12:45 +00:00
internal_defines.h
Lint fix for webrtc/modules/video_coding PART 2!
2015-12-21 12:12:45 +00:00
jitter_buffer_common.h
Lint fix for webrtc/modules/video_coding PART 2!
2015-12-21 12:12:45 +00:00
jitter_buffer_unittest.cc
Add support for Location (RTC_FROM_HERE) to ProcessThread::RegisterModule.
2017-03-03 11:20:24 +00:00
jitter_buffer.cc
Remove ALL usage of CriticalSectionWrapper.
2017-03-31 09:03:55 +00:00
jitter_buffer.h
Remove ALL usage of CriticalSectionWrapper.
2017-03-31 09:03:55 +00:00
jitter_estimator_tests.cc
Fix cpplint errors in locations that are already being checked
2017-03-24 10:22:49 +00:00
jitter_estimator.cc
Prevent zero division in VCMJitterEstimator.
2016-02-01 15:31:17 +00:00
jitter_estimator.h
Wire up VCMTiming in FrameBuffer2.
2016-08-03 08:59:47 +00:00
media_opt_util.cc
Rename fec_tables_xor.h -> fec_rate_table.h
2017-01-12 14:16:24 +00:00
media_opt_util.h
Delete unneeded includes of deprecated system_wrappers include files.
2017-03-30 07:31:15 +00:00
media_optimization.cc
Revert of Periodically update codec bit/frame rate settings. (patchset #8 id:140001 of https://codereview.webrtc.org/2883963002/ )
2017-06-07 13:17:49 +00:00
media_optimization.h
Delete unneeded includes of deprecated system_wrappers include files.
2017-03-30 07:31:15 +00:00
nack_fec_tables.h
Lint fix for webrtc/modules/video_coding PART 2!
2015-12-21 12:12:45 +00:00
nack_module_unittest.cc
Reland of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.
2017-01-10 12:21:35 +00:00
nack_module.cc
Remove |running_| state from NackModule to avoid running a tight loop.
2017-02-27 09:59:36 +00:00
nack_module.h
Remove |running_| state from NackModule to avoid running a tight loop.
2017-02-27 09:59:36 +00:00
OWNERS
Updating VCM owners to reflect current active persons in the project.
2017-05-11 07:28:18 +00:00
packet_buffer.cc
Dont request keyframes if the stream is inactive or if we are currently receiving a keyframe.
2017-05-18 15:08:53 +00:00
packet_buffer.h
Dont request keyframes if the stream is inactive or if we are currently receiving a keyframe.
2017-05-18 15:08:53 +00:00
packet.cc
Reland of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.
2017-01-10 12:21:35 +00:00
packet.h
Remove deprecated isFirstPacket member name
2017-05-23 18:06:56 +00:00
protection_bitrate_calculator_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
protection_bitrate_calculator.cc
Remove frame rate and target bitrate from ProtectionBitrateCalculator::SetEncodingData
2016-07-11 08:47:36 +00:00
protection_bitrate_calculator.h
Remove frame rate and target bitrate from ProtectionBitrateCalculator::SetEncodingData
2016-07-11 08:47:36 +00:00
qp_parser.cc
Add vp9 QP parser.
2017-05-24 17:00:16 +00:00
qp_parser.h
Refactor + enable GN check on video_coding_utility
2017-03-08 13:42:26 +00:00
receiver_unittest.cc
Delete unneeded includes of deprecated system_wrappers include files.
2017-03-30 07:31:15 +00:00
receiver.cc
remove more CriticalSectionWrappers.
2017-03-27 14:24:57 +00:00
receiver.h
remove more CriticalSectionWrappers.
2017-03-27 14:24:57 +00:00
rtp_frame_reference_finder_unittest.cc
Don't recalculate Tl0PicIdx when the VP9 frame has no Tl0PicIdx.
2017-03-20 17:42:13 +00:00
rtp_frame_reference_finder.cc
Stashed frames are now retried in a loop rather than recursively.
2017-04-26 15:17:35 +00:00
rtp_frame_reference_finder.h
Stashed frames are now retried in a loop rather than recursively.
2017-04-26 15:17:35 +00:00
rtt_filter.cc
Lint fix for webrtc/modules/video_coding PART 2!
2015-12-21 12:12:45 +00:00
rtt_filter.h
Lint fix for webrtc/modules/video_coding PART 2!
2015-12-21 12:12:45 +00:00
sequence_number_util_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
sequence_number_util.h
Moved sequence number specific operations from mod_ops.h
2016-03-22 09:03:55 +00:00
session_info_unittest.cc
Reland of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.
2017-01-10 12:21:35 +00:00
session_info.cc
Reland of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.
2017-01-10 12:21:35 +00:00
session_info.h
Revert "Revert of Use sps and pps to determine decodability of H.264 frames. (patchset #4 id:60001 of https://codereview.webrtc.org/2341713002/ )"
2016-10-06 12:04:59 +00:00
timestamp_map.cc
Lint fix for webrtc/modules/video_coding PART 3!
2015-12-21 16:23:29 +00:00
timestamp_map.h
Replace scoped_ptr with unique_ptr in webrtc/modules/video_coding/
2016-02-29 13:52:06 +00:00
timing_unittest.cc
Delete unneeded includes of deprecated system_wrappers include files.
2017-03-30 07:31:15 +00:00
timing.cc
remove more CriticalSectionWrappers.
2017-03-27 14:24:57 +00:00
timing.h
remove more CriticalSectionWrappers.
2017-03-27 14:24:57 +00:00
video_codec_initializer_unittest.cc
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ )
2017-04-05 10:02:20 +00:00
video_codec_initializer.cc
Refactor + enable GN check on video_coding_utility
2017-03-08 13:42:26 +00:00
video_coding_impl.cc
remove more CriticalSectionWrappers.
2017-03-27 14:24:57 +00:00
video_coding_impl.h
Revert of Deliver video frames on Android, on the decode thread. (patchset #7 id:120001 of https://codereview.webrtc.org/2764573002/ )
2017-04-04 14:16:21 +00:00
video_packet_buffer_unittest.cc
Cast sequence number in RtpFrameObject.
2017-05-23 15:19:11 +00:00
video_receiver_unittest.cc
Updates to VCMDecodedFrameCallback, VideoReceiver and a few related classes/tests.
2017-03-14 11:16:20 +00:00
video_receiver.cc
Revert of Deliver video frames on Android, on the decode thread. (patchset #7 id:120001 of https://codereview.webrtc.org/2764573002/ )
2017-04-04 14:16:21 +00:00
video_sender_unittest.cc
Delete unused test code in modules/video_coding/test/
2017-03-17 15:11:11 +00:00
video_sender.cc
Revert "Update video_coding/codecs to new VideoFrameBuffer interface"
2017-06-08 08:33:52 +00:00