admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/sdk/objc/api/peerconnection
History
Benjamin Williams ab009c27b4 Refactor WebRTC self assignments in if clauses 
This change refactors existing self-assignments within if clauses across
the WebRTC codebase.

*Why:*

- Bug Prevention: Assignments within conditionals are frequently
  unintended errors, often mistaken for equality checks.

- Clearer Code: Separating assignments from conditionals improves code
  readability and reduces the risk of misinterpretation.

Change-Id: I199dc26a35ceca109a2ac569b446811314dfdf0b
Bug: chromium:361594695
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360460
Reviewed-by: Chuck Hays <haysc@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42850}
2024-08-26 15:56:43 +00:00
..
RTCAudioSource.h
Use backticks not vertical bars to denote variables in comments for /sdk
2021-07-27 14:39:06 +00:00
RTCAudioSource.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCAudioSource+Private.h
…
RTCAudioTrack.h
…
RTCAudioTrack.mm
Revert "Add a prefix for objc category."
2022-05-13 14:47:54 +00:00
RTCAudioTrack+Private.h
…
RTCCertificate.h
…
RTCCertificate.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCConfiguration.h
Reland^2 "Reland: Remove unsupported configuration value, allow_codec_switching"
2023-11-22 13:22:08 +00:00
RTCConfiguration.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCConfiguration+Native.h
…
RTCConfiguration+Private.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCCryptoOptions.h
Rename rtc_base/ssl_stream_adapter.h constants.
2021-07-26 16:33:54 +00:00
RTCCryptoOptions.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCDataChannel.h
Use backticks not vertical bars to denote variables in comments
2021-08-10 10:40:03 +00:00
RTCDataChannel.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCDataChannel+Private.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCDataChannelConfiguration.h
…
RTCDataChannelConfiguration.mm
Revert "Add a prefix for objc category."
2022-05-13 14:47:54 +00:00
RTCDataChannelConfiguration+Private.h
…
RTCDtmfSender.h
…
RTCDtmfSender.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCDtmfSender+Private.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCEncodedImage+Private.h
…
RTCEncodedImage+Private.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCFieldTrials.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCFieldTrials.mm
Remove default enabled field trial WebRTC-SendSideBwe-WithOverhead
2022-11-30 20:19:36 +00:00
RTCFileLogger.h
Use backticks not vertical bars to denote variables in comments for /sdk
2021-07-27 14:39:06 +00:00
RTCFileLogger.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCIceCandidate.h
…
RTCIceCandidate.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCIceCandidate+Private.h
…
RTCIceCandidateErrorEvent.h
Implement JNI and objc implementation for icecandidateerror event
2021-12-14 14:19:38 +00:00
RTCIceCandidateErrorEvent.mm
Revert "Add a prefix for objc category."
2022-05-13 14:47:54 +00:00
RTCIceCandidateErrorEvent+Private.h
Implement JNI and objc implementation for icecandidateerror event
2021-12-14 14:19:38 +00:00
RTCIceServer.h
Use backticks not vertical bars to denote variables in comments for /sdk
2021-07-27 14:39:06 +00:00
RTCIceServer.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCIceServer+Private.h
…
RTCLegacyStatsReport.h
…
RTCLegacyStatsReport.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCLegacyStatsReport+Private.h
Delete api/stats_types.h in favor of api/legacy_stats_types.h
2022-11-14 12:10:06 +00:00
RTCMediaConstraints.h
…
RTCMediaConstraints.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCMediaConstraints+Private.h
…
RTCMediaSource.h
…
RTCMediaSource.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCMediaSource+Private.h
…
RTCMediaStream.h
…
RTCMediaStream.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCMediaStream+Private.h
…
RTCMediaStreamTrack.h
…
RTCMediaStreamTrack.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCMediaStreamTrack+Private.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCMetrics.h
…
RTCMetrics.mm
Adopt absl::string_view in system_wrappers/
2022-05-17 08:23:24 +00:00
RTCMetricsSampleInfo.h
…
RTCMetricsSampleInfo.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCMetricsSampleInfo+Private.h
…
RTCPeerConnection.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCPeerConnection.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCPeerConnection+DataChannel.mm
Revert "Add a prefix for objc category."
2022-05-13 14:47:54 +00:00
RTCPeerConnection+Private.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCPeerConnection+Stats.mm
Revert "Add a prefix for objc category."
2022-05-13 14:47:54 +00:00
RTCPeerConnectionFactory.h
Expose setCodecPreferences/getCapabilities for iOS
2024-01-23 13:54:26 +00:00
RTCPeerConnectionFactory.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCPeerConnectionFactory+Native.h
[iwyu][1\n] Applying to api/[a-s]*
2024-06-19 06:19:20 +00:00
RTCPeerConnectionFactory+Private.h
Expose network thread in RTCPeerConnectionFactory+Private.
2023-04-11 10:25:10 +00:00
RTCPeerConnectionFactoryBuilder.h
[iwyu][1\n] Applying to api/[a-s]*
2024-06-19 06:19:20 +00:00
RTCPeerConnectionFactoryBuilder.mm
Move webrtc::AudioDeviceModule include to api/ folder
2024-04-22 08:56:31 +00:00
RTCPeerConnectionFactoryBuilder+DefaultComponents.h
…
RTCPeerConnectionFactoryBuilder+DefaultComponents.mm
…
RTCPeerConnectionFactoryOptions.h
…
RTCPeerConnectionFactoryOptions.mm
…
RTCPeerConnectionFactoryOptions+Private.h
…
RTCRtcpParameters.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtcpParameters.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtcpParameters+Private.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpCapabilities.h
Expose setCodecPreferences/getCapabilities for iOS
2024-01-23 13:54:26 +00:00
RTCRtpCapabilities.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtpCapabilities+Private.h
Expose setCodecPreferences/getCapabilities for iOS
2024-01-23 13:54:26 +00:00
RTCRtpCodecCapability.h
Expose setCodecPreferences/getCapabilities for iOS
2024-01-23 13:54:26 +00:00
RTCRtpCodecCapability.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtpCodecCapability+Private.h
Expose setCodecPreferences/getCapabilities for iOS
2024-01-23 13:54:26 +00:00
RTCRtpCodecParameters.h
Fix typo in a URL in the comment
2021-05-31 20:15:17 +00:00
RTCRtpCodecParameters.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtpCodecParameters+Private.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpEncodingParameters.h
Expose adaptive_ptime from iOS SDK.
2021-04-18 21:53:32 +00:00
RTCRtpEncodingParameters.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtpEncodingParameters+Private.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpHeaderExtension.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpHeaderExtension.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtpHeaderExtension+Private.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpHeaderExtensionCapability.h
Expose setCodecPreferences/getCapabilities for iOS
2024-01-23 13:54:26 +00:00
RTCRtpHeaderExtensionCapability.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtpHeaderExtensionCapability+Private.h
Expose setCodecPreferences/getCapabilities for iOS
2024-01-23 13:54:26 +00:00
RTCRtpParameters.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpParameters.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtpParameters+Private.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpReceiver.h
Expose RTCRtpReceiver.sources.
2024-05-24 13:08:35 +00:00
RTCRtpReceiver.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtpReceiver+Native.h
…
RTCRtpReceiver+Private.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCRtpSender.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCRtpSender.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtpSender+Native.h
…
RTCRtpSender+Private.h
…
RTCRtpSource.h
Expose RTCRtpReceiver.sources.
2024-05-24 13:08:35 +00:00
RTCRtpSource.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtpSource+Private.h
Expose RTCRtpReceiver.sources.
2024-05-24 13:08:35 +00:00
RTCRtpTransceiver.h
[iOS] Make RTCRtpTransceiver.setCodecPreferences failable and accept nil
2024-08-16 08:45:39 +00:00
RTCRtpTransceiver.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCRtpTransceiver+Private.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCSessionDescription.h
Revert "An RTCSessionDescription will now return nil from its initializer if the SDP passed to it is invalid."
2021-07-31 09:53:46 +00:00
RTCSessionDescription.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCSessionDescription+Private.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCSSLAdapter.h
…
RTCSSLAdapter.mm
…
RTCStatisticsReport.h
Support for map of string keys to uint64_t / double values in RTCStats
2021-05-25 20:38:08 +00:00
RTCStatisticsReport.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCStatisticsReport+Private.h
Format /sdk
2023-04-21 04:30:57 +00:00
RTCTracing.h
…
RTCTracing.mm
…
RTCVideoCodecInfo+Private.h
…
RTCVideoCodecInfo+Private.mm
Revert "Add a prefix for objc category."
2022-05-13 14:47:54 +00:00
RTCVideoEncoderSettings+Private.h
…
RTCVideoEncoderSettings+Private.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCVideoSource.h
…
RTCVideoSource.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCVideoSource+Private.h
Add ability to mark video sources for screen casting in ObjC
2021-08-21 08:19:12 +00:00
RTCVideoTrack.h
…
RTCVideoTrack.mm
Refactor WebRTC self assignments in if clauses
2024-08-26 15:56:43 +00:00
RTCVideoTrack+Private.h
…