843b6f503f
This CL fixes a crash that could happen when JSON event tracing is shutting down. The cause of the crash was the fact that the logger thread function was returning 'true', causing the platform thread to run it repeatedly even though that wasn't the intention. Usually the EventLogger::Stop() function would set the event requesting the logging thread to clean up and close the file, and then immediately call PlatformThread::Stop() which would stop the outer loop. The Log() function would only run once and everything behaves as expected. However, if a context switch happens between the shutdown_event_.Set() and logging_thread_.Stop() calls in EventLogger::Stop(), the logger thread function would close the file and exit the Log() method, while PlatformThread will rerun it again. So the Log() function runs twice, and the second time output_file_ is NULL which either causes the DCHECK to fail (in debug builds) or the fprintf() to crash with SIGSEGV (in release builds). The fix simply changes the return value of the thread function to false so it never runs twice. R=pthatcher@webrtc.org Review URL: https://codereview.webrtc.org/2168283002 . Cr-Commit-Position: refs/heads/master@{#13510}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
Development
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://chromium.googlesource.com/external/webrtc
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: http://build.chromium.org/p/client.webrtc