82c94af48f
This reverts commit d67903d284353dffcf28dfb92819e3d7c4b69bfd. Reason for revert: A downstream issue needs to be fixed. Original change's description: > Make MockPeerConnectionInterface not inherit from RefCountedObject > > Bug: webrtc:12701 > Change-Id: I51fb7caf12b97d70f35af12703104112f9fdfaff > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256107 > Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#36267} Bug: webrtc:12701 Change-Id: I25e2d6004d257dd0b1d17fb1f7726d04d29e6eed Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256109 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36271}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.