825e4f19ce
The `requested_resolution` API must not change aspect ratio, example: - Frame is 60x30 - Requested is 30x30 - We expect 30x15 (not 30x30!) as to maintain aspect ratio. This bug was previously fixed by making VideoAdapter unaware of the requested resolution behind a flag: this seemed OK since the VideoStreamEncoder ultimately decides the resolution, whether or not the incoming frame is adapted. But this is not desired for some non-Chrome use cases. This CL attempts to make both Chrome and non-Chrome use cases happy by implementing the aspect ratio preserving restriction inside VideoAdapter too. This allows us to get rid of the "use_standard_requested_resolution" flag and change the "VideoStreamEncoderResolutionTest" TEST_P to TEST_F. Bug: webrtc:366067962, webrtc:366284861 Change-Id: I1dfd10963274c5fdfd18d0f4443b2f209d2e9a4b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362720 Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43037}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.- Avoid structs in api, prefer classes.
The preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.
Avoid defining api with structs as it makes harder for the api to evolve. Your struct may gain invariant, or change how it represents data. Evolving struct from the api is particular challenging as it is designed to be used in other code bases and thus needs to be updated independetly from its usage. Class with accessors and setters makes such migration safer. See Google C++ style guide for more.
If you need to evolve existent struct in api, prefer first to convert it into a class.