37827c9058
This reverts commit 444e04be6988fbdcc039d775481ac22481ff9ff4. Reason for revert: breaks downstream project Original change's description: > ChannelStatistics used for RTP stats in VoipStatistics. > > - Added local and remote RTP statistics query API. > - Change includes simplifying remote SSRC change handling > via received RTP and RTCP packets. > > Bug: webrtc:11989 > Change-Id: Ia3ee62c1191baaedc67e033ea3c661d8c9301abc > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/199060 > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Commit-Queue: Tim Na <natim@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32954} TBR=mbonadei@webrtc.org,saza@webrtc.org,hta@webrtc.org,natim@webrtc.org Change-Id: I5ce6a698c1216c7d56e32fce3308c16daac852f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:11989 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/201460 Reviewed-by: Alex Loiko <aleloi@google.com> Commit-Queue: Alex Loiko <aleloi@google.com> Cr-Commit-Position: refs/heads/master@{#32956}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.