admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/modules/rtp_rtcp/source
History
Erik Språng 6841d25d45 Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const" 
This is a reland of 17608dc4592fe25c1effdd75bf856f4af251942e

Downstream test now fixed.
As a precaution, also avoid DCHECKS for non-zero SSRC.
First patch set is reland, second makes checks more lenient.

Original change's description:
> RtpRtcp modules and below: Make media, RTX and FEC SSRCs const
>
> Downstream usage of SetSsrc() / SetRtxSsrc() should now be gone. Let's
> remove them, make the members const, and remove now unnecessary locking.
>
> Bug: webrtc:10774
> Change-Id: Ie4c1b3935508cf329c5553030f740c565d32e04b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/155660
> Commit-Queue: Erik Språng <sprang@webrtc.org>
> Reviewed-by: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29475}

Bug: webrtc:10774
Change-Id: I540b49a31a31e98d87f02ae04083d5206e71c1b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157100
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29491}
2019-10-15 14:03:19 +00:00
..
rtcp_packet
Replace virtual RtcpPacket::SetSenderSsrc with base member
2019-10-10 09:14:11 +00:00
absolute_capture_time_receiver_unittest.cc
Add helper classes to send and receive abs-capture-time extensions.
2019-08-22 09:09:17 +00:00
absolute_capture_time_receiver.cc
Add helper classes to send and receive abs-capture-time extensions.
2019-08-22 09:09:17 +00:00
absolute_capture_time_receiver.h
Add helper classes to send and receive abs-capture-time extensions.
2019-08-22 09:09:17 +00:00
absolute_capture_time_sender_unittest.cc
Add helper classes to send and receive abs-capture-time extensions.
2019-08-22 09:09:17 +00:00
absolute_capture_time_sender.cc
Add helper classes to send and receive abs-capture-time extensions.
2019-08-22 09:09:17 +00:00
absolute_capture_time_sender.h
Add helper classes to send and receive abs-capture-time extensions.
2019-08-22 09:09:17 +00:00
byte_io_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
byte_io.h
Format almost everything.
2019-07-08 13:45:15 +00:00
dtmf_queue.cc
[Cleanup] Add missing #include. Remove useless ones.
2018-10-23 11:32:56 +00:00
dtmf_queue.h
Format almost everything.
2019-07-08 13:45:15 +00:00
fec_private_tables_bursty_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
fec_private_tables_bursty.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
fec_private_tables_bursty.h
Delete root header file typedef.h.
2018-07-25 14:59:26 +00:00
fec_private_tables_random.cc
Remove part of the FEC code table that covers FEC code for group of 13-48 media packets, instead generate interleaved FEC code at run time. FEC code masks for protection of group of 1 - 12 media packets is not changed.
2018-04-18 14:35:17 +00:00
fec_private_tables_random.h
Delete root header file typedef.h.
2018-07-25 14:59:26 +00:00
fec_test_helper.cc
Cleanup passing rtp packet to ulpfec receiver.
2019-09-20 11:09:11 +00:00
fec_test_helper.h
Cleanup passing rtp packet to ulpfec receiver.
2019-09-20 11:09:11 +00:00
flexfec_header_reader_writer_unittest.cc
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
flexfec_header_reader_writer.cc
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
flexfec_header_reader_writer.h
[Cleanup] Add missing #include. Remove useless ones.
2018-10-23 11:32:56 +00:00
flexfec_receiver_unittest.cc
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
flexfec_receiver.cc
Add Slice method to CopyOnWriteBuffer and use it in FEC code.
2019-09-26 09:48:07 +00:00
flexfec_sender_unittest.cc
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
flexfec_sender.cc
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
forward_error_correction_internal.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
forward_error_correction_internal.h
[Cleanup] Add missing #include. Remove useless ones.
2018-10-23 11:32:56 +00:00
forward_error_correction.cc
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
forward_error_correction.h
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
nack_rtx_unittest.cc
Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"
2019-10-15 14:03:19 +00:00
packet_loss_stats_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
packet_loss_stats.cc
[Cleanup] Add missing #include. Remove useless ones.
2018-10-23 11:32:56 +00:00
packet_loss_stats.h
Format almost everything.
2019-07-08 13:45:15 +00:00
playout_delay_oracle_unittest.cc
Refactor PlayoutDelayOracle with separate update methods
2019-01-30 16:50:24 +00:00
playout_delay_oracle.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
playout_delay_oracle.h
Move ownership of RTPSenderVideo one more level up, to RtpVideoSender
2019-03-04 16:57:49 +00:00
receive_statistics_impl.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
receive_statistics_impl.h
Delete deprecated method StreamStatistician::GetStatistics
2019-09-05 14:12:24 +00:00
receive_statistics_unittest.cc
Consolidate FEC book-keeping
2019-08-28 06:56:12 +00:00
remote_ntp_time_estimator_unittest.cc
Fix 28 ClangTidy - Readability findings in modules/rtp_rtcp/
2019-09-04 07:38:20 +00:00
remote_ntp_time_estimator.cc
[Cleanup] Add missing #include. Remove useless ones.
2018-10-23 11:32:56 +00:00
rtcp_nack_stats_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtcp_nack_stats.cc
[Cleanup] Add missing #include. Remove useless ones.
2018-10-23 11:32:56 +00:00
rtcp_nack_stats.h
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtcp_packet_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtcp_packet.cc
Enable padding bit in TransportFeedback packets
2019-02-12 11:55:34 +00:00
rtcp_packet.h
Replace virtual RtcpPacket::SetSenderSsrc with base member
2019-10-10 09:14:11 +00:00
rtcp_receiver_unittest.cc
Rename RtpRtcp::Configuration::media_send_ssrc to local_media_ssrc
2019-08-21 09:45:21 +00:00
rtcp_receiver.cc
Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"
2019-10-15 14:03:19 +00:00
rtcp_receiver.h
Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"
2019-10-15 14:03:19 +00:00
rtcp_sender_unittest.cc
Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"
2019-10-15 14:03:19 +00:00
rtcp_sender.cc
Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"
2019-10-15 14:03:19 +00:00
rtcp_sender.h
Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"
2019-10-15 14:03:19 +00:00
rtcp_transceiver_config.cc
Calculate RTT using ExtendedReports in RtcpTransceiver
2017-11-30 14:34:40 +00:00
rtcp_transceiver_config.h
in RtcpTransceiver remove workaround for old bug in RtcpReceiver
2018-11-19 10:13:02 +00:00
rtcp_transceiver_impl_unittest.cc
Fix 28 ClangTidy - Readability findings in modules/rtp_rtcp/
2019-09-04 07:38:20 +00:00
rtcp_transceiver_impl.cc
Add void::RtcpFeedbackSenderInterface::SendCombinedRtcpPacket
2019-10-10 12:05:49 +00:00
rtcp_transceiver_impl.h
Add void::RtcpFeedbackSenderInterface::SendCombinedRtcpPacket
2019-10-10 12:05:49 +00:00
rtcp_transceiver_unittest.cc
Add void::RtcpFeedbackSenderInterface::SendCombinedRtcpPacket
2019-10-10 12:05:49 +00:00
rtcp_transceiver.cc
Add void::RtcpFeedbackSenderInterface::SendCombinedRtcpPacket
2019-10-10 12:05:49 +00:00
rtcp_transceiver.h
Add void::RtcpFeedbackSenderInterface::SendCombinedRtcpPacket
2019-10-10 12:05:49 +00:00
rtp_dependency_descriptor_extension.cc
Implement Dependency Descriptor writer
2019-09-19 08:51:40 +00:00
rtp_dependency_descriptor_extension.h
Implement Dependency Descriptor writer
2019-09-19 08:51:40 +00:00
rtp_dependency_descriptor_reader.cc
Add fuzzer testing for Dependency Descriptor rtp header extension
2019-09-20 12:40:24 +00:00
rtp_dependency_descriptor_reader.h
Implement Dependency Descriptor reader
2019-09-16 15:55:54 +00:00
rtp_dependency_descriptor_writer.cc
Implement Dependency Descriptor writer
2019-09-19 08:51:40 +00:00
rtp_dependency_descriptor_writer.h
Implement Dependency Descriptor writer
2019-09-19 08:51:40 +00:00
rtp_fec_unittest.cc
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
rtp_format_h264_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_format_h264.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_format_h264.h
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_format_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_format_video_generic_unittest.cc
Reduce number of RTPVideoSender::SendVideo parameters
2019-10-11 10:59:21 +00:00
rtp_format_video_generic.cc
Reduce number of RTPVideoSender::SendVideo parameters
2019-10-11 10:59:21 +00:00
rtp_format_video_generic.h
Reduce number of RTPVideoSender::SendVideo parameters
2019-10-11 10:59:21 +00:00
rtp_format_vp8_test_helper.cc
Cleanup RtpPacketizerVP8 tests
2018-08-31 08:13:45 +00:00
rtp_format_vp8_test_helper.h
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
rtp_format_vp8_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_format_vp8.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_format_vp8.h
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_format_vp9_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_format_vp9.cc
Reject invalid spatial index
2019-10-14 12:24:01 +00:00
rtp_format_vp9.h
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_format.cc
Reduce number of RTPVideoSender::SendVideo parameters
2019-10-11 10:59:21 +00:00
rtp_format.h
Reduce number of RTPVideoSender::SendVideo parameters
2019-10-11 10:59:21 +00:00
rtp_generic_frame_descriptor_extension_unittest.cc
Always pass arguments to INSTANTIATE_TEST_SUITE_P.
2019-09-24 08:56:24 +00:00
rtp_generic_frame_descriptor_extension.cc
Create version 01 of Generic Frame Descriptor - with discardability flag
2019-02-20 10:31:58 +00:00
rtp_generic_frame_descriptor_extension.h
Create version 01 of Generic Frame Descriptor - with discardability flag
2019-02-20 10:31:58 +00:00
rtp_generic_frame_descriptor.cc
Ensure GenericFrameDescriptor byte representation match
2018-12-04 11:52:25 +00:00
rtp_generic_frame_descriptor.h
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_header_extension_map_unittest.cc
Move RtpHeaderExtensionMap::GetTotalLengthInBytes into own file
2018-10-03 17:25:31 +00:00
rtp_header_extension_map.cc
Cleanup: Replacing set extension status bool with CHECK.
2019-10-15 12:55:46 +00:00
rtp_header_extension_size_unittest.cc
Move RtpHeaderExtensionMap::GetTotalLengthInBytes into own file
2018-10-03 17:25:31 +00:00
rtp_header_extension_size.cc
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
rtp_header_extension_size.h
Move RtpHeaderExtensionMap::GetTotalLengthInBytes into own file
2018-10-03 17:25:31 +00:00
rtp_header_extensions.cc
Include module_common_types.h only where needed
2019-09-24 08:22:38 +00:00
rtp_header_extensions.h
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_packet_history_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
rtp_packet_history.cc
Include module_common_types.h only where needed
2019-09-24 08:22:38 +00:00
rtp_packet_history.h
Reland "Improve performance of RtpPacketHistory"
2019-09-11 11:07:29 +00:00
rtp_packet_received.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_packet_received.h
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_packet_to_send.cc
[Cleanup] Add missing #include. Remove useless ones.
2018-10-23 11:32:56 +00:00
rtp_packet_to_send.h
Revert "Simplify pacer queue"
2019-09-01 12:59:06 +00:00
rtp_packet_unittest.cc
Deprecate legacy RtpHeaderExtensionMap::Register function
2019-09-12 17:04:01 +00:00
rtp_packet.cc
Fix handling of large packets in RtxReceiveStream
2019-10-10 08:39:46 +00:00
rtp_packet.h
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
rtp_rtcp_config.h
Delete unused constants from rtp_rtcp_config.h
2018-08-09 08:38:51 +00:00
rtp_rtcp_impl_unittest.cc
Reduce number of RTPVideoSender::SendVideo parameters
2019-10-11 10:59:21 +00:00
rtp_rtcp_impl.cc
Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"
2019-10-15 14:03:19 +00:00
rtp_rtcp_impl.h
Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"
2019-10-15 14:03:19 +00:00
rtp_sender_audio_unittest.cc
Deprecate legacy RtpHeaderExtensionMap::Register function
2019-09-12 17:04:01 +00:00
rtp_sender_audio.cc
Remove usage of StorageType enum
2019-08-27 16:48:33 +00:00
rtp_sender_audio.h
Remove usage of StorageType enum
2019-08-27 16:48:33 +00:00
rtp_sender_unittest.cc
Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"
2019-10-15 14:03:19 +00:00
rtp_sender_video_unittest.cc
Reduce number of RTPVideoSender::SendVideo parameters
2019-10-11 10:59:21 +00:00
rtp_sender_video.cc
Remove deprecated functions in RTPSenderVideo
2019-10-14 13:12:29 +00:00
rtp_sender_video.h
Remove deprecated functions in RTPSenderVideo
2019-10-14 13:12:29 +00:00
rtp_sender.cc
Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"
2019-10-15 14:03:19 +00:00
rtp_sender.h
Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"
2019-10-15 14:03:19 +00:00
rtp_sequence_number_map_unittest.cc
Always pass arguments to INSTANTIATE_TEST_SUITE_P.
2019-09-24 08:56:24 +00:00
rtp_sequence_number_map.cc
Add RtpSequenceNumberMap::InsertFrame()
2019-04-08 12:39:08 +00:00
rtp_sequence_number_map.h
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_utility_unittest.cc
Add writing and parsing of the abs-capture-time RTP header extension.
2019-07-03 14:07:36 +00:00
rtp_utility.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_utility.h
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_video_header.cc
Add default values for PlayoutDelay in RTPVideoHeader.
2018-11-16 12:10:23 +00:00
rtp_video_header.h
Move frame_type member from RtpDepacketizer::ParsedPayload to RTPVideoHeader
2019-04-24 13:13:04 +00:00
source_tracker_unittest.cc
Always pass arguments to INSTANTIATE_TEST_SUITE_P.
2019-09-24 08:56:24 +00:00
source_tracker.cc
Add a tracker for RTCRtpContributingSource and RTCRtpSynchronizationSource.
2019-06-12 12:11:55 +00:00
source_tracker.h
Split out RtpSource from libjingle_peerconnection_api
2019-09-02 14:04:47 +00:00
time_util_unittest.cc
Removes TimeMicros interface from ThreadProcessingFakeClock.
2019-04-17 15:37:48 +00:00
time_util.cc
Delete modules/rtp_rtcp local DivideRoundToNearest in favor on one in rtc_base
2019-09-19 08:10:12 +00:00
time_util.h
In ReceiveStatistics use monotonic clock instead of ntp clock
2018-11-26 10:31:44 +00:00
tmmbr_help.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
tmmbr_help.h
Format almost everything.
2019-07-08 13:45:15 +00:00
ulpfec_generator_unittest.cc
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
ulpfec_generator.cc
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
ulpfec_generator.h
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
ulpfec_header_reader_writer_unittest.cc
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
ulpfec_header_reader_writer.cc
Reland "Refactor FEC code to use COW buffers"
2019-09-09 16:20:33 +00:00
ulpfec_header_reader_writer.h
[Cleanup] Add missing #include. Remove useless ones.
2018-10-23 11:32:56 +00:00
ulpfec_receiver_impl.cc
In ulpfec receiver check for malformed packets to avoid DCHECKS tirggering
2019-09-30 10:40:31 +00:00
ulpfec_receiver_impl.h
Cleanup passing rtp packet to ulpfec receiver.
2019-09-20 11:09:11 +00:00
ulpfec_receiver_unittest.cc
Cleanup passing rtp packet to ulpfec receiver.
2019-09-20 11:09:11 +00:00