050ffefd85
This CL extends logging related to HW->SW fallbacks on the encoder side in WebRTC. The goal is to make it easier to track down the different steps taken when setting up the video encoder and why/when HW encoding fails. Current logs are added on several lines which makes regexp searching difficult. This CL adds all related information on one line instead. Three new search tags are also added VSE (VideoStreamEncoder), VESFW (VideoEncoderSoftwareFallbackWrapper) and SEA (SimulcastEncoderAdapter). The idea is to allow searching for the tags to see correlated logs. It has been verified that these added logs also show up in WebRTC logs in Meet. Logs from the GPU process are not included due to the sandboxed nature which makes it much more complex to add to the native WebRTC log. I think that these simple logs will provide value as is. Example: https://gist.github.com/henrik-and/41946f7f0b10774241bd14d7687f770b Bug: b/322132132 Change-Id: Iec58c9741a9dd6bab3236a88e9a6e45440f5d980 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339260 Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41733}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.- Avoid structs in api, prefer classes.
The preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.
Avoid defining api with structs as it makes harder for the api to evolve. Your struct may gain invariant, or change how it represents data. Evolving struct from the api is particular challenging as it is designed to be used in other code bases and thus needs to be updated independetly from its usage. Class with accessors and setters makes such migration safer. See Google C++ style guide for more.
If you need to evolve existent struct in api, prefer first to convert it into a class.