7e6290d1d2
This reverts commit 72f638a9a279e7abb5534fa66a0ade2cf18ec1a7. Reason for revert: downstream build failures Original change's description: > Use CRYPTO_BUFFER APIs instead of X509 when building with BoringSSL. > > Using CRYPTO_BUFFERs instead of legacy X509 objects offers memory and > security gains, and will provide binary size improvements as well once > the default list of built-in certificates can be removed; the code > dealing with them still depends on the X509 API. > > Implemented by splitting openssl_identity and openssl_certificate > into BoringSSL and vanilla OpenSSL implementations. > > Bug: webrtc:11410 > Change-Id: Idc043462faac5e4ab1b75bedab2057197f80aba6 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174120 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: David Benjamin <davidben@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Taylor <deadbeef@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32811} TBR=deadbeef@webrtc.org,mbonadei@webrtc.org,davidben@webrtc.org,hta@webrtc.org Change-Id: Ib5e55cb5798a2f3d25a4460f5311d2e650d3fa82 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:11410 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196742 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32812}
87 lines
2.6 KiB
C++
87 lines
2.6 KiB
C++
/*
|
|
* Copyright 2018 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/openssl_session_cache.h"
|
|
|
|
#include <openssl/ssl.h>
|
|
#include <stdlib.h>
|
|
|
|
#include <map>
|
|
#include <memory>
|
|
|
|
#include "rtc_base/gunit.h"
|
|
#include "rtc_base/openssl.h"
|
|
|
|
namespace rtc {
|
|
|
|
TEST(OpenSSLSessionCache, DTLSModeSetCorrectly) {
|
|
SSL_CTX* ssl_ctx = SSL_CTX_new(DTLSv1_2_client_method());
|
|
|
|
OpenSSLSessionCache session_cache(SSL_MODE_DTLS, ssl_ctx);
|
|
EXPECT_EQ(session_cache.GetSSLMode(), SSL_MODE_DTLS);
|
|
|
|
SSL_CTX_free(ssl_ctx);
|
|
}
|
|
|
|
TEST(OpenSSLSessionCache, TLSModeSetCorrectly) {
|
|
SSL_CTX* ssl_ctx = SSL_CTX_new(TLSv1_2_client_method());
|
|
|
|
OpenSSLSessionCache session_cache(SSL_MODE_TLS, ssl_ctx);
|
|
EXPECT_EQ(session_cache.GetSSLMode(), SSL_MODE_TLS);
|
|
|
|
SSL_CTX_free(ssl_ctx);
|
|
}
|
|
|
|
TEST(OpenSSLSessionCache, SSLContextSetCorrectly) {
|
|
SSL_CTX* ssl_ctx = SSL_CTX_new(DTLSv1_2_client_method());
|
|
|
|
OpenSSLSessionCache session_cache(SSL_MODE_DTLS, ssl_ctx);
|
|
EXPECT_EQ(session_cache.GetSSLContext(), ssl_ctx);
|
|
|
|
SSL_CTX_free(ssl_ctx);
|
|
}
|
|
|
|
TEST(OpenSSLSessionCache, InvalidLookupReturnsNullptr) {
|
|
SSL_CTX* ssl_ctx = SSL_CTX_new(DTLSv1_2_client_method());
|
|
|
|
OpenSSLSessionCache session_cache(SSL_MODE_DTLS, ssl_ctx);
|
|
EXPECT_EQ(session_cache.LookupSession("Invalid"), nullptr);
|
|
EXPECT_EQ(session_cache.LookupSession(""), nullptr);
|
|
EXPECT_EQ(session_cache.LookupSession("."), nullptr);
|
|
|
|
SSL_CTX_free(ssl_ctx);
|
|
}
|
|
|
|
TEST(OpenSSLSessionCache, SimpleValidSessionLookup) {
|
|
SSL_CTX* ssl_ctx = SSL_CTX_new(DTLSv1_2_client_method());
|
|
SSL_SESSION* ssl_session = SSL_SESSION_new(ssl_ctx);
|
|
|
|
OpenSSLSessionCache session_cache(SSL_MODE_DTLS, ssl_ctx);
|
|
session_cache.AddSession("webrtc.org", ssl_session);
|
|
EXPECT_EQ(session_cache.LookupSession("webrtc.org"), ssl_session);
|
|
|
|
SSL_CTX_free(ssl_ctx);
|
|
}
|
|
|
|
TEST(OpenSSLSessionCache, AddToExistingReplacesPrevious) {
|
|
SSL_CTX* ssl_ctx = SSL_CTX_new(DTLSv1_2_client_method());
|
|
SSL_SESSION* ssl_session_1 = SSL_SESSION_new(ssl_ctx);
|
|
SSL_SESSION* ssl_session_2 = SSL_SESSION_new(ssl_ctx);
|
|
|
|
OpenSSLSessionCache session_cache(SSL_MODE_DTLS, ssl_ctx);
|
|
session_cache.AddSession("webrtc.org", ssl_session_1);
|
|
session_cache.AddSession("webrtc.org", ssl_session_2);
|
|
EXPECT_EQ(session_cache.LookupSession("webrtc.org"), ssl_session_2);
|
|
|
|
SSL_CTX_free(ssl_ctx);
|
|
}
|
|
|
|
} // namespace rtc
|