7cfbf3a0ff
An energy value is calculated by summing squares of processed audio samples. The expression 'out*out >> 6' could overflow. In this CL we change it to 'out*(out>>6) + out*(out*(out%(1<<6))>>6)'. The which is verified and proven to be equal, but doesn't overflow. The change also passes our change-detection tests in GainControlBitExactnessTest.* We verified with Godbolt that the modulo and divisions are converted into branch-free bitwise operations. NOTRY=True # changing comment, tests just passed. Bug: chromium:780638, chromium:780376 Change-Id: I415535193433a2fbc275c643fb4e4026ba3e0bdd Reviewed-on: https://webrtc-review.googlesource.com/20867 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20589}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: http://build.chromium.org/p/client.webrtc
- Coding style guide
- Code of conduct