3edccb999c
Reason for revert: Fixing and re-landing. Original issue's description: > Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) > > Reason for revert: > ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. > #include "webrtc/base/checks.h" > ^------------------- > The target: > //webrtc/test:fileutils_unittests > is including a file from the target: > //webrtc/base:rtc_base_approved > > It's usually best to depend directly on the destination target. > In some cases, the destination target is considered a subcomponent > of an intermediate target. In this case, the intermediate target > should depend publicly on the destination to forward the ability > to include headers. > > Dependency chain (there may also be others): > //webrtc/test:fileutils_unittests --> > //webrtc/test:fileutils --[private]--> > //webrtc/base:rtc_base_approved > > > Original issue's description: > > Enabling `gn check` on webrtc/test > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2911203002 > > Cr-Commit-Position: refs/heads/master@{#18372} > > Committed:db5bb404b0> > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2920763002 > Cr-Commit-Position: refs/heads/master@{#18375} > Committed:1a6f143d07TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2918793002 Cr-Commit-Position: refs/heads/master@{#18376}
61 lines
2.3 KiB
Plaintext
61 lines
2.3 KiB
Plaintext
# Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
import("//build/dotfile_settings.gni")
|
|
|
|
# The location of the build configuration file.
|
|
buildconfig = "//build/config/BUILDCONFIG.gn"
|
|
|
|
# The secondary source root is a parallel directory tree where
|
|
# GN build files are placed when they can not be placed directly
|
|
# in the source tree, e.g. for third party source trees.
|
|
secondary_source = "//build/secondary/"
|
|
|
|
# These are the targets to check headers for by default. The files in targets
|
|
# matching these patterns (see "gn help label_pattern" for format) will have
|
|
# their includes checked for proper dependencies when you run either
|
|
# "gn check" or "gn gen --check".
|
|
# TODO(kjellander): Keep adding paths to this list as work in webrtc:5589 is done.
|
|
check_targets = [
|
|
"//webrtc/api/*",
|
|
"//webrtc/audio/*",
|
|
"//webrtc/base/*",
|
|
"//webrtc/call/*",
|
|
"//webrtc/common_video/*",
|
|
"//webrtc/common_audio/*",
|
|
"//webrtc/examples/*",
|
|
"//webrtc/logging/*",
|
|
"//webrtc/media/*",
|
|
"//webrtc/modules/*",
|
|
"//webrtc/ortc/*",
|
|
"//webrtc/p2p/*",
|
|
"//webrtc/sdk/*",
|
|
"//webrtc/stats/*",
|
|
"//webrtc/system_wrappers/*",
|
|
"//webrtc/test/*",
|
|
"//webrtc/tools/*",
|
|
"//webrtc/video/*",
|
|
"//webrtc/voice_engine/*",
|
|
]
|
|
|
|
# These are the list of GN files that run exec_script. This whitelist exists
|
|
# to force additional review for new uses of exec_script, which is strongly
|
|
# discouraged except for gypi_to_gn calls.
|
|
exec_script_whitelist = build_dotfile_settings.exec_script_whitelist
|
|
|
|
default_args = {
|
|
# Webrtc does not support component builds because we are not using the
|
|
# template "component" but we rely directly on "rtc_static_library" and
|
|
# "rtc_shared_library". This means that we cannot use the chromium default
|
|
# value for this argument.
|
|
# This also means that the user can override this value using --args or
|
|
# the args.gn file but this setting will be ignored because we don't support
|
|
# component builds.
|
|
is_component_build = false
|
|
}
|